simulator: add optional listName to config.lua#4
Open
XeduR wants to merge 3 commits intocoronalabs:masterfrom
Open
simulator: add optional listName to config.lua#4XeduR wants to merge 3 commits intocoronalabs:masterfrom
XeduR wants to merge 3 commits intocoronalabs:masterfrom
Conversation
- Extract current year from buildNum instead of hardcoding - Fix start year from 2020 to 2009 to match original Corona SDK release year (same as in the Console copyright message)
Simulator only: Users can now define listName property inside config.lua's application table. Handles missing and malformed config.lua gracefully. If listName property is not defined, then Simulator falls back to default behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to define
listNameproperty inside config.lua'sapplicationtable.Missing or malformed config.lua is handled gracefully. If
listNameproperty is not defined, then Simulator falls back on default behaviour, i.e. this will not affect any existing projects. Projects will need to addapplication.listNameto their config.lua to see any changes.This change only affects the display texts in the Simulator's Recent Projects. This change does not affect the build process or anything else.
Current behaviour
Solar2D Simulator picks the project's display name based on the folder where the project's main.lua file is located. This can result in non-descriptive and even duplicate project names in the list.
New behaviour
Insert
listName(string) to config.lua and the project's name changes in the Simulator's Recent Projects list. This allows developers to control exactly how their projects appear in the list.config.lua: