refactor: streamline Set serialization and improve condition expression documentation

Author: arnog

src/compute-engine/latex-syntax/dictionary/definitions-sets.ts

@@ -594,34 +594,7 @@ function serializeSet(
   const h = operator(expr);
   if (!h) return '';
 
-  //
-  // `Set`
-  //
-  if (h === 'Set') {
-    if (nops(expr) === 0) return '\\emptyset';
-
-    //
-    // 1/ First variant: ["Set", <set | predicate>, ["Condition"]]
-    //
-    if (nops(expr) === 2 && operator(operand(expr, 2)) === 'Condition') {
-      return joinLatex([
-        '\\left\\lbrace',
-        serializer.serialize(operand(expr, 1)),
-        '\\middle\\mid',
-        serializer.serialize(operand(expr, 2)),
-        '\\right\\rbrace',
-      ]);
-    }
-
-    //
-    // 2/ 2nd variant: ["Set", ...<sequence>]
-    //
-    return joinLatex([
-      '\\left\\lbrace',
-      ...operands(expr).map((x) => serializer.serialize(x) + ' ,'),
-      '\\right\\rbrace',
-    ]);
-  }
+  // Note: `Set` serialization is handled by the matchfix entry's inline serializer.
 
   //
   // Multiple

src/compute-engine/library/control-structures.ts

@@ -27,12 +27,14 @@ export const CONTROL_STRUCTURES_LIBRARY: SymbolDefinitions[] = [
       evaluate: evaluateBlock,
     },
 
-    // A condition expression tests for one or more conditions of an expression
-    // ['Condition', value, "positive"]
+    // A condition expression tests for one or more conditions of an expression.
+    // Two forms:
+    //   ['Condition', value, "positive"]  — tests value against named condition(s)
+    //   ['Condition', predicate]          — set-builder predicate (e.g. x > 0)
     Condition: {
       description: 'Test whether a value satisfies one or more conditions.',
       lazy: true,
-      signature: '(value, symbol) -> boolean',
+      signature: '(expression, symbol?) -> boolean',
       evaluate: ([value, conds], { engine }) => {
         let conditions: string[] = [];
         if (isSymbol(conds)) {

test/compute-engine/latex-syntax/sets.test.ts

@@ -25,9 +25,7 @@ describe('SERIALIZING SETS', () => {
   });
 
   test('Complement', () => {
-    expect(latex(['Complement', 'A'])).toMatchInlineSnapshot(
-      `A^\\complement`
-    );
+    expect(latex(['Complement', 'A'])).toMatchInlineSnapshot(`A^\\complement`);
   });
 
   // test('Range', () => {});
@@ -718,10 +716,6 @@ describe('SET BUILDER NOTATION', () => {
             x,
             0,
           ],
-          [
-            Error,
-            missing,
-          ],
         ],
       ]
     `);
@@ -744,10 +738,6 @@ describe('SET BUILDER NOTATION', () => {
             x,
             0,
           ],
-          [
-            Error,
-            missing,
-          ],
         ],
       ]
     `);
@@ -767,10 +757,6 @@ describe('SET BUILDER NOTATION', () => {
             x,
             0,
           ],
-          [
-            Error,
-            missing,
-          ],
         ],
       ]
     `);
@@ -790,10 +776,6 @@ describe('SET BUILDER NOTATION', () => {
             x,
             0,
           ],
-          [
-            Error,
-            missing,
-          ],
         ],
       ]
     `);