config: silence migration warning for legacy enabled=true (no-op)

The legacy-enabled migration shim correctly stripped 'enabled: true' from
dreamer/sidekick config in-memory (the key is no longer valid and the value
is a no-op alias for the new default 'disable: false'), but it surfaced a
config warning suggesting the user had something to fix.

This made users with auto-generated configs (LLM-authored, dashboard-written,
or carried forward from before unification) see a 'Magic Context Config
Warning' dialog on every restart even though their config was semantically
equivalent to the new default. The warning was misleading because nothing
needs migrating — the field is simply obsolete.

Keep the warning only when a real semantic value is present:
  - dreamer.enabled=false → migrated to disable=true (loud, behavior changes)
  - sidekick.enabled=false → migrated to disable=true (loud)
  - historian.enabled=<any> → removed (loud, was always invalid)
  - dreamer.enabled=true → stripped silently (no-op alias)
  - sidekick.enabled=true → stripped silently (no-op alias)

Doctor still cleans both true and false from disk on next run.

Author: ualtinok

packages/plugin/src/config/agent-disable.ts

@@ -53,11 +53,8 @@ function migrateLegacyEnabledForAgent(args: {
             args.warnings.push(
                 'Migrated "dreamer.enabled=false" → "dreamer.disable=true" in-memory (run doctor to persist). This now also disables manual /ctx-dream; for manual-only remove disable and set schedule="".',
             );
-        } else {
-            args.warnings.push(
-                'Ignored deprecated "dreamer.enabled=true" in-memory (run doctor to remove).',
-            );
         }
+        // enabled=true is a no-op alias for the new default (disable=false); strip silently.
         args.patched.dreamer = agent;
         return;
     }
@@ -67,11 +64,8 @@ function migrateLegacyEnabledForAgent(args: {
         args.warnings.push(
             'Migrated "sidekick.enabled=false" → "sidekick.disable=true" in-memory (run doctor to persist).',
         );
-    } else {
-        args.warnings.push(
-            'Ignored deprecated "sidekick.enabled=true" in-memory (run doctor to remove).',
-        );
     }
+    // enabled=true is a no-op alias for the new default; strip silently.
     args.patched.sidekick = agent;
 }
 

packages/plugin/src/config/index.test.ts

@@ -251,17 +251,18 @@ describe("loadPluginConfig — legacy agent enabled migration", () => {
         );
     });
 
-    it("removes dreamer.enabled=true without adding disable=false", () => {
+    it("removes dreamer.enabled=true silently (no warning, no disable mutation)", () => {
         const result = loadWithUserConfig(JSON.stringify({ dreamer: { enabled: true } }));
 
         expect(result.dreamer?.disable).toBeUndefined();
         expect("enabled" in (result.dreamer as Record<string, unknown>)).toBe(false);
-        expect(result.configWarnings?.join("\n")).toContain(
-            'Ignored deprecated "dreamer.enabled=true" in-memory (run doctor to remove).',
-        );
+        // enabled=true is a no-op alias for the new default; no warning should be emitted.
+        const warnings = result.configWarnings?.join("\n") ?? "";
+        expect(warnings).not.toContain("dreamer.enabled=true");
+        expect(warnings).not.toContain("dreamer.enabled");
     });
 
-    it("migrates sidekick.enabled=false and removes sidekick.enabled=true", () => {
+    it("migrates sidekick.enabled=false (loud) and removes sidekick.enabled=true (silent)", () => {
         const disabled = loadWithUserConfig(JSON.stringify({ sidekick: { enabled: false } }));
         expect(disabled.sidekick?.disable).toBe(true);
         expect(disabled.configWarnings?.join("\n")).toContain(
@@ -271,6 +272,8 @@ describe("loadPluginConfig — legacy agent enabled migration", () => {
         const enabled = loadWithUserConfig(JSON.stringify({ sidekick: { enabled: true } }));
         expect(enabled.sidekick?.disable).toBeUndefined();
         expect("enabled" in (enabled.sidekick as Record<string, unknown>)).toBe(false);
+        const enabledWarnings = enabled.configWarnings?.join("\n") ?? "";
+        expect(enabledWarnings).not.toContain("sidekick.enabled");
     });
 
     it("removes invalid historian.enabled and applies conflict rules", () => {