fix: avoid rendering empty env key in querier deployment#650
Merged
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
nschad
approved these changes
Jul 4, 2026
kd7lxl
approved these changes
Jul 9, 2026
Comment on lines
+91
to
+93
| {{- if .Values.querier.env }} | ||
| env: | ||
| {{- if .Values.querier.env }} | ||
| {{- toYaml .Values.querier.env | nindent 12 }} | ||
| {{- end }} | ||
| {{- toYaml .Values.querier.env | nindent 12 }} |
Collaborator
There was a problem hiding this comment.
Cleaner syntax for this is:
Suggested change
| {{- if .Values.querier.env }} | |
| env: | |
| {{- if .Values.querier.env }} | |
| {{- toYaml .Values.querier.env | nindent 12 }} | |
| {{- end }} | |
| {{- toYaml .Values.querier.env | nindent 12 }} | |
| {{- with .Values.querier.env }} | |
| env: | |
| {{- toYaml . | nindent 12 }} |
kd7lxl
enabled auto-merge (squash)
July 9, 2026 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The querier deployment renders an empty
env:key when no environment variables are configured. Wrapped in conditional to match existig pattern.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]