Fix lint failures: update CI for Go 1.24 and golangci-lint v1.64

- Update validate_pr.yml to use Go 1.24 matching go.mod requirement
- Upgrade golangci-lint from v1.54 to v1.64 (supports Go 1.24)
- Upgrade golangci-lint-action from v4 to v6
- Update .golangci.yml: use disable-all with explicit linter list,
  fix deprecated config options (output.format -> output.formats,
  errcheck.exclude -> removed)
- Rename min/max functions in cmd/sim/main.go to avoid shadowing
  Go 1.21+ builtins (revive: redefines-builtin-id)
- Rename 'new' parameter in CompareNamespaces to 'updated' to avoid
  shadowing builtin (revive: redefines-builtin-id)
- Remove accidentally committed blockgen binary

Co-authored-by: CharlieTLe <3375195+CharlieTLe@users.noreply.github.com>

Author: Copilot

.github/workflows/validate_pr.yml

@@ -12,20 +12,20 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: '1.24'
           cache: false
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v4
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54
+          version: v1.64
   unit_tests:
     name: Unit-Tests
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: '1.24'
       - name: Unit Tests
         run: make test
   build:
@@ -35,6 +35,6 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: '1.24'
       - name: Build All
         run: make all

.golangci.yml

@@ -6,17 +6,17 @@ run:
     - require_docker
 
 output:
-  format: line-number
+  formats:
+    - format: line-number
 
 linters:
+  disable-all: true
   enable:
     - goimports
     - revive
     - misspell
     - gofmt
 
 linters-settings:
-  errcheck:
-    exclude: .errcheck-exclude
   goimports:
     local-prefixes: "github.com/cortexproject/cortex-tools"

blockgen

@@ -116,8 +116,8 @@ func run(k int, sizer func(float64) int) {
 
 	fmt.Printf("%d, %d, %d, %d, %f, %f\n",
 		k,
-		int(min(nodeSeries)),
-		int(max(nodeSeries)),
+		int(minFloat64(nodeSeries)),
+		int(maxFloat64(nodeSeries)),
 		int(stat.Mean(nodeSeries, nil)),
 		stat.StdDev(nodeSeries, nil),
 		float64(maxAffectedTenants)/float64(numTenants))
@@ -168,7 +168,7 @@ func shuffleShard(entropy *rand.Rand, shardSize, numReplicas int) []int {
 	return ids
 }
 
-func min(fs []float64) float64 {
+func minFloat64(fs []float64) float64 {
 	result := math.MaxFloat64
 	for _, f := range fs {
 		if f < result {
@@ -178,7 +178,7 @@ func min(fs []float64) float64 {
 	return result
 }
 
-func max(fs []float64) float64 {
+func maxFloat64(fs []float64) float64 {
 	result := 0.0
 	for _, f := range fs {
 		if f > result {

cmd/sim/main.go

@@ -131,9 +131,9 @@ func rulesEqual(a, b *rulefmt.Rule) bool {
 
 // CompareNamespaces returns the differences between the two provided
 // namespaces
-func CompareNamespaces(original, new RuleNamespace) NamespaceChange {
+func CompareNamespaces(original, updated RuleNamespace) NamespaceChange {
 	result := NamespaceChange{
-		Namespace:     new.Namespace,
+		Namespace:     updated.Namespace,
 		State:         Unchanged,
 		GroupsUpdated: []UpdatedRuleGroup{},
 		GroupsCreated: []rwrulefmt.RuleGroup{},
@@ -145,7 +145,7 @@ func CompareNamespaces(original, new RuleNamespace) NamespaceChange {
 		origMap[g.Name] = g
 	}
 
-	for _, newGroup := range new.Groups {
+	for _, newGroup := range updated.Groups {
 		origGroup, found := origMap[newGroup.Name]
 		if !found {
 			result.State = Updated