Skip to content

Commit db89bf7

Browse files
committed
Fix integration tests
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
1 parent 7e1f11e commit db89bf7

1 file changed

Lines changed: 13 additions & 14 deletions

File tree

integration/integration_test.go

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
"github.com/prometheus/prometheus/promql/parser"
2626
"github.com/prometheus/prometheus/storage/remote"
2727
"github.com/stretchr/testify/require"
28-
"gopkg.in/yaml.v3"
2928

3029
"github.com/cortexproject/cortex-tools/pkg/backfill"
3130
"github.com/cortexproject/cortex-tools/pkg/bench"
@@ -50,10 +49,10 @@ func newClient(t *testing.T) *client.CortexClient {
5049
return c
5150
}
5251

53-
func ruleNode(record, expr string) rulefmt.RuleNode {
54-
return rulefmt.RuleNode{
55-
Record: yaml.Node{Kind: yaml.ScalarNode, Value: record},
56-
Expr: yaml.Node{Kind: yaml.ScalarNode, Value: expr},
52+
func rule(record, expr string) rulefmt.Rule {
53+
return rulefmt.Rule{
54+
Record: record,
55+
Expr: expr,
5756
}
5857
}
5958

@@ -64,8 +63,8 @@ func TestRulesLoadListDelete(t *testing.T) {
6463
namespace := "test_namespace"
6564
group := rwrulefmt.RuleGroup{}
6665
group.Name = "test_rule_group"
67-
group.Rules = []rulefmt.RuleNode{
68-
ruleNode("summed_up", "sum(up)"),
66+
group.Rules = []rulefmt.Rule{
67+
rule("summed_up", "sum(up)"),
6968
}
7069

7170
err := c.CreateRuleGroup(ctx, namespace, group)
@@ -106,9 +105,9 @@ func TestRulesMultipleGroups(t *testing.T) {
106105

107106
namespace := "multi_group_namespace"
108107
groups := []rwrulefmt.RuleGroup{
109-
{RuleGroup: rulefmt.RuleGroup{Name: "group_a", Rules: []rulefmt.RuleNode{ruleNode("metric_a", "sum(up)")}}},
110-
{RuleGroup: rulefmt.RuleGroup{Name: "group_b", Rules: []rulefmt.RuleNode{ruleNode("metric_b", "count(up)")}}},
111-
{RuleGroup: rulefmt.RuleGroup{Name: "group_c", Rules: []rulefmt.RuleNode{ruleNode("metric_c", "avg(up)")}}},
108+
{RuleGroup: rulefmt.RuleGroup{Name: "group_a", Rules: []rulefmt.Rule{rule("metric_a", "sum(up)")}}},
109+
{RuleGroup: rulefmt.RuleGroup{Name: "group_b", Rules: []rulefmt.Rule{rule("metric_b", "count(up)")}}},
110+
{RuleGroup: rulefmt.RuleGroup{Name: "group_c", Rules: []rulefmt.Rule{rule("metric_c", "avg(up)")}}},
112111
}
113112

114113
for _, g := range groups {
@@ -407,11 +406,11 @@ func (i *timeSeriesIterator) Labels() labels.Labels {
407406
return i.labels
408407
}
409408
series := i.ts[i.posSeries]
410-
i.labels = make(labels.Labels, len(series.Labels))
411-
for idx := range series.Labels {
412-
i.labels[idx].Name = series.Labels[idx].Name
413-
i.labels[idx].Value = series.Labels[idx].Value
409+
b := labels.NewBuilder(labels.EmptyLabels())
410+
for _, l := range series.Labels {
411+
b.Set(l.Name, l.Value)
414412
}
413+
i.labels = b.Labels()
415414
i.labelsSeriesPos = i.posSeries
416415
return i.labels
417416
}

0 commit comments

Comments
 (0)