Skip to content

Commit 55e300e

Browse files
authored
fix: increase WaitActiveInstanceTimeout in TestCompactor_RingLifecyclerShouldAutoForgetUnhealthyInstances (#7503)
The test was flaky because WaitActiveInstanceTimeout (5s from prepareConfig) was too tight when combined with WaitStabilityMinDuration=1s and WaitStabilityMaxDuration=5s. On slow CI machines, the ring lifecycler may not transition to ACTIVE within 5s, causing a context deadline exceeded error at StartAndAwaitRunning. Increase WaitActiveInstanceTimeout to 30s to give sufficient headroom for the ring to stabilize on slow CI environments. Signed-off-by: Ben Ye <benye@amazon.com>
1 parent 4abf274 commit 55e300e

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

pkg/compactor/compactor_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2201,6 +2201,7 @@ func TestCompactor_RingLifecyclerShouldAutoForgetUnhealthyInstances(t *testing.T
22012201
cfg.ShardingRing.InstanceAddr = fmt.Sprintf("127.0.0.%d", i)
22022202
cfg.ShardingRing.WaitStabilityMinDuration = time.Second
22032203
cfg.ShardingRing.WaitStabilityMaxDuration = 5 * time.Second
2204+
cfg.ShardingRing.WaitActiveInstanceTimeout = 30 * time.Second
22042205
cfg.ShardingRing.KVStore.Mock = kvstore
22052206
cfg.ShardingRing.HeartbeatPeriod = 200 * time.Millisecond
22062207
cfg.ShardingRing.UnregisterOnShutdown = false

0 commit comments

Comments
 (0)