Skip to content

Commit 851ea5d

Browse files
committed
Fix timeout failure
With WaitMissingMetrics, the e2e helper keeps retrying on missing cache hits/misses until timeout. Signed-off-by: Siddarth Gundu <siddarthg0910@gmail.com>
1 parent a54504f commit 851ea5d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

integration/querier_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ func TestQuerierWithBlocksStorageRunningInSingleBinaryMode(t *testing.T) {
266266
}
267267

268268
if testCfg.bucketStorageType == "parquet" {
269-
require.NoError(t, cluster.WaitSumMetricsWithOptions(e2e.Greater(0), []string{"cortex_parquet_row_ranges_cache_misses_total"}, e2e.WaitMissingMetrics))
269+
require.NoError(t, cluster.WaitSumMetricsWithOptions(e2e.Greater(0), []string{"cortex_parquet_row_ranges_cache_misses_total"}, e2e.SkipMissingMetrics))
270270
}
271271

272272
if testCfg.indexCacheBackend == tsdb.IndexCacheBackendMemcached {
@@ -284,7 +284,7 @@ func TestQuerierWithBlocksStorageRunningInSingleBinaryMode(t *testing.T) {
284284
require.NoError(t, cluster.WaitSumMetrics(e2e.Equals(float64((12+2)*seriesReplicationFactor)), "thanos_store_index_cache_requests_total"))
285285
require.NoError(t, cluster.WaitSumMetrics(e2e.Equals(float64(2*seriesReplicationFactor)), "thanos_store_index_cache_hits_total")) // this time has used the index cache
286286
case "parquet":
287-
require.NoError(t, cluster.WaitSumMetricsWithOptions(e2e.Greater(0), []string{"cortex_parquet_row_ranges_cache_hits_total"}, e2e.WaitMissingMetrics))
287+
require.NoError(t, cluster.WaitSumMetricsWithOptions(e2e.Greater(0), []string{"cortex_parquet_row_ranges_cache_hits_total"}, e2e.SkipMissingMetrics))
288288
switch testCfg.parquetLabelsCache {
289289
case tsdb.CacheBackendInMemory:
290290
require.NoError(t, cluster.WaitSumMetrics(e2e.Greater(float64(0)), "thanos_cache_inmemory_requests_total"))

0 commit comments

Comments
 (0)