Skip to content

Commit 03ada1e

Browse files
committed
feat(DEVC-1286): few updates
1 parent 4df6f04 commit 03ada1e

1 file changed

Lines changed: 15 additions & 8 deletions

File tree

src/corva/cache_adapter.py

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,20 @@ def __init__(self, hash_name: str, client: redis.Redis):
9191
self.zset_name = f'{hash_name}.EXPIREAT'
9292
self.client = client
9393

94+
def _proper_redis_server_version(self) -> bool:
95+
# Require Redis 7.4+ for per-field TTL commands
96+
redis_version_str = self.client.info(section="server").get("redis_version")
97+
98+
if not redis_version_str:
99+
return False
100+
101+
server_version = semver.Version.parse(version=redis_version_str)
102+
103+
if server_version < self.MINIMUM_ALLOWED_REDIS_SERVER:
104+
return False
105+
106+
return True
107+
94108
def run(self) -> bool:
95109
"""Migrate from old Lua+ZSET per-field TTL to Redis built-in per-field TTL.
96110
@@ -109,14 +123,7 @@ def run(self) -> bool:
109123
if not self.client.exists(self.zset_name):
110124
return False
111125

112-
# Require Redis 7.4+ for per-field TTL commands
113-
redis_version_str = self.client.info(section="server").get("redis_version")
114-
if not redis_version_str:
115-
return False
116-
117-
server_version = semver.Version.parse(version=redis_version_str)
118-
119-
if server_version < self.MINIMUM_ALLOWED_REDIS_SERVER:
126+
if not self._proper_redis_server_version():
120127
return False
121128

122129
from corva import Logger

0 commit comments

Comments
 (0)