feat(DEVC-265): add py typed for improve type hinting#109
Closed
kossman wants to merge 8 commits into
Closed
Conversation
YevherniiFeshchenko
approved these changes
Sep 11, 2025
corva-alex-s
approved these changes
Sep 11, 2025
Contributor
Author
|
Will be shipped as a part of that PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Ensure app code quality developed by users that use type hinting and
mypystatic type checker.Goal
Currently
mypywill skipcorva-sdk. Add apy.typedfile so thatmypywill know to use our type annotations.Changes
Typing metadata
src/corva/py.typedmypy
>=1.10,<2mypypyproject.tomlpython_version="3.9",mypy_path="src"explicit_package_bases``check_untyped_defsdocs.*``ignore_errors``ignore_missing_imports``ignore_missing_imports``mock.*``tests.*Code tweaks for stricter typing
cast(...)and a single# type: ignore[call-arg]Jira task
DEVC-265