Skip to content

feat(DEVC-265): add py typed for improve type hinting#109

Closed
kossman wants to merge 8 commits into
masterfrom
feature/DEVC-265-add-py-typed-for-improve-type-hinting
Closed

feat(DEVC-265): add py typed for improve type hinting#109
kossman wants to merge 8 commits into
masterfrom
feature/DEVC-265-add-py-typed-for-improve-type-hinting

Conversation

@kossman

@kossman kossman commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Rationale

Ensure app code quality developed by users that use type hinting and mypy static type checker.

Goal

Currently mypy will skip corva-sdk. Add a py.typed file so that mypy will know to use our type annotations.

Changes

  • Typing metadata

    • Add src/corva/py.typed
    • Include package data; add “Typing :: Typed” classifier
  • mypy

    • Bump to >=1.10,<2
    • Move CLI flags into ; Makefile runs plain mypy pyproject.toml
    • Set python_version="3.9", mypy_path="src"
    • Enable , explicit_package_bases``check_untyped_defs
    • Clean up overrides: + ; keep third‑party ; silence and docs.*``ignore_errors``ignore_missing_imports``ignore_missing_imports``mock.*``tests.*
    • Remove ad-hoc exclude patterns for docs tutorials
  • Code tweaks for stricter typing

    • Add targeted cast(...) and a single # type: ignore[call-arg]

Jira task

DEVC-265

@kossman kossman self-assigned this Sep 9, 2025
@kossman kossman changed the title Feature/devc 265 add py typed for improve type hinting feature(DEVC-265): add py typed for improve type hinting Sep 10, 2025
@kossman kossman changed the title feature(DEVC-265): add py typed for improve type hinting feat(DEVC-265): add py typed for improve type hinting Sep 18, 2025
@kossman

kossman commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

Will be shipped as a part of that PR

@kossman kossman closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants