feat: avoid duplicate logs in cloudwatch#112
Merged
kossman merged 9 commits intoOct 15, 2025
Merged
Conversation
But still maintain the OTel handlers.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Corva logging system to prevent duplicate log entries in CloudWatch while preserving OpenTelemetry (OTel) log handling functionality. The solution disables log propagation on the CORVA_LOGGER and explicitly attaches OTel handlers when log sending is enabled.
Key changes:
- Disables propagation on CORVA_LOGGER to prevent AWS Lambda root handler duplication
- Adds utility functions to detect and gather OTel handlers from the root logger
- Modifies LoggingContext to explicitly attach OTel handlers when appropriate
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…b.com:corva-ai/python-sdk into feature/improve-corva-logging-with-cloudwatch
smoke
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But still maintain the OTel handlers.
Rationale
Remove the duplicate logging in CloudWatch, but still maintain the OpenTelemetry handlers.
TODO