Skip to content

Fix tests to use proper AST node construction and types#12

Open
corydolphin wants to merge 6 commits into
make-visitor-immutable-friendlyfrom
fix-tests-to-use-proper-ast-node
Open

Fix tests to use proper AST node construction and types#12
corydolphin wants to merge 6 commits into
make-visitor-immutable-friendlyfrom
fix-tests-to-use-proper-ast-node

Conversation

@corydolphin

Copy link
Copy Markdown
Owner
  • Update test_visitor.py to properly type-annotate the visitor class attribute
    and add assertion before using selection_set
  • Update test_schema_parser.py to use more precise types that match GraphQL spec:
    • NonNullTypeNode's inner type can only be NamedTypeNode or ListTypeNode
    • Schema definitions use ConstDirectiveNode, not DirectiveNode
    • Default values use ConstValueNode, not ValueNode
    • OperationTypeDefinition's type_ must be NamedTypeNode

Thank you for contributing to GraphQL-core!

If your pull-request is non-trivial, adds a feature or contains a non-breaking change, then please, first open an issue to discuss the proposed changes and add a link to that issue.

GraphQL-core tries very hard to stay within the scope of being just a Python port of GraphQL.js.

Any additional feature or incompatible change will be only accepted in rare cases and requires a compelling reason, because they aggravate maintenance and synchronization with the developments in the upstream project. So please discuss such changes upfront in an issue before sending a PR. Maybe there are other ways to solve the problem.

If possible, also add unit tests, or provide runnable example code as part of the accompanying issue, from which unit tests can be derived.

- Update test_visitor.py to properly type-annotate the visitor class attribute
  and add assertion before using selection_set
- Update test_schema_parser.py to use more precise types that match GraphQL spec:
  - NonNullTypeNode's inner type can only be NamedTypeNode or ListTypeNode
  - Schema definitions use ConstDirectiveNode, not DirectiveNode
  - Default values use ConstValueNode, not ValueNode
  - OperationTypeDefinition's type_ must be NamedTypeNode
@corydolphin corydolphin force-pushed the fix-tests-to-use-proper-ast-node branch from 8a48871 to 6c91ccf Compare January 7, 2026 05:17
corydolphin and others added 5 commits January 8, 2026 14:20
Introduce benchmarks using a large GraphQL query to measure
parse and pickle serialization performance. These provide a baseline
for comparing serialization approaches in subsequent commits.
…thon#251)

Prepares AST for immutability by using tuples instead of lists for
collection fields. This aligns with the JavaScript GraphQL library
which uses readonly arrays, and enables future frozen datastructures.
Python 3.9 reached end-of-life October 2025.
Python 3.10 adoption is now mainstream.

The stable branch still supports the old versions.

Type hints and code still need to be adapted.
Modifies the AST visitor to use copy-on-write semantics when applying
edits. Instead of mutating nodes in place, the visitor now creates new
node instances with the edited values. This prepares for frozen AST
nodes while maintaining backwards compatibility.

The visitor accumulates edits and applies them by constructing new
nodes, enabling the transition to immutable data structures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants