Fixing a bug in MultiSceneTransitionTask

MultiSceneTransitionTask was not clearing the waiting boolean every loop and thus could get stuck forever waiting

Author: Cory Leach

Runtime/TransitionSystem/SceneTransitionTask.cs

@@ -18,12 +18,12 @@ public async Task ExecuteAsync()
 
             //Start Loads
             var loadOperation = SceneManager.LoadSceneAsync(SceneName, Mode);
-            
+
             if (loadOperation == null)
             {
                 return;
             }
-            
+
             //Allow them all to load till 90% complete
             loadOperation.allowSceneActivation = false;
 
@@ -34,13 +34,13 @@ public async Task ExecuteAsync()
             }
 
             loadOperation.allowSceneActivation = true;
-            
+
             while (!loadOperation.isDone)
             {
                 Progress = loadOperation.progress;
                 await Task.Yield();
             }
-            
+
             ListPool<AsyncOperation>.Release(loadTasks);
 
             //Load should now be complete
@@ -50,7 +50,7 @@ public async Task ExecuteAsync()
             await Task.Yield();
         }
     }
-    
+
     public class MultiSceneTransitionTask : ITransitionTask
     {
         public string[] UnloadScenes { get; set; }
@@ -62,11 +62,11 @@ public async Task ExecuteAsync()
         {
             var unloadTasks = ListPool<AsyncOperation>.Get();
             var loadTasks = ListPool<AsyncOperation>.Get();
-            
+
             Progress = 0;
-            
+
             int totalScenes = UnloadScenes.Length + LoadScenes.Length;
-            
+
             //Start Unloads
             for (var index = 0; index < UnloadScenes.Length; index++)
             {
@@ -100,13 +100,15 @@ public async Task ExecuteAsync()
             }
 
             var waiting = false;
-            
+
             do
             {
                 await Task.Yield();
 
                 float sumProgress = 0;
 
+                waiting = false;
+
                 for (var index = 0; index < unloadTasks.Count; index++)
                 {
                     var unload = unloadTasks[index];
@@ -147,9 +149,9 @@ public async Task ExecuteAsync()
 
             //Load should now be complete
             Progress = 1f;
-            
+
             //Yielding one last time to let the 100% progress to be handled by presenter
             await Task.Yield();
         }
     }
-}
+}