fix(solana): optimize signature verification for Cosmoshub#1022
Open
vaporif wants to merge 18 commits into
Open
fix(solana): optimize signature verification for Cosmoshub#1022vaporif wants to merge 18 commits into
vaporif wants to merge 18 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 27 27
Lines 1123 1123
=======================================
Hits 1122 1122
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
PR author is not in the allowed authors list. |
srdtrk
reviewed
Apr 15, 2026
| } | ||
|
|
||
| /// Owner check runs first so unrelated accounts skip the syscall. | ||
| fn verify_header_chunk_pda( |
Member
There was a problem hiding this comment.
add docs as to what this does. And maybe rename
srdtrk
reviewed
Apr 16, 2026
Member
srdtrk
left a comment
There was a problem hiding this comment.
Lgtm. I'll leave it open for now due to the audit,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
e2e test via
(might worth adding this to CI since this test never runs and was broken before)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.