Rename X auth env vars for release announcements

Author: Rieranthony

.github/workflows/release.yml

@@ -248,10 +248,10 @@ jobs:
           DISCORD_RELEASE_WEBHOOK_URL: ${{ secrets.DISCORD_RELEASE_WEBHOOK_URL }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           REPOSITORY: ${{ github.repository }}
+          X_CONSUMER_KEY: ${{ secrets.X_CONSUMER_KEY }}
+          X_CONSUMER_KEY_SECRET: ${{ secrets.X_CONSUMER_KEY_SECRET }}
           X_ACCESS_TOKEN: ${{ secrets.X_ACCESS_TOKEN }}
           X_ACCESS_TOKEN_SECRET: ${{ secrets.X_ACCESS_TOKEN_SECRET }}
-          X_API_KEY: ${{ secrets.X_API_KEY }}
-          X_API_SECRET: ${{ secrets.X_API_SECRET }}
         shell: bash
         run: |
           args=(

packages/release/src/announcement.test.ts

@@ -5,6 +5,7 @@ import fs from "fs-extra";
 import {
 	type AnnouncementContext,
 	appendAnnouncementMarker,
+	buildXOAuth1,
 	loadChangelogRelease,
 	prepareStoredDiscordAnnouncement,
 	prepareStoredXAnnouncement,
@@ -401,4 +402,38 @@ Release summary.
 			"Skipped because the changelog frontmatter is empty"
 		);
 	});
+
+	it("builds OAuth1 auth with the X dashboard consumer env vars", () => {
+		const oauth1 = buildXOAuth1({
+			X_CONSUMER_KEY: "consumer-key",
+			X_CONSUMER_KEY_SECRET: "consumer-secret",
+			X_ACCESS_TOKEN: "access-token",
+			X_ACCESS_TOKEN_SECRET: "access-token-secret",
+		});
+		const config = (oauth1 as any).config as {
+			apiKey: string;
+			apiSecret: string;
+			callback: string;
+			accessToken: string;
+			accessTokenSecret: string;
+		};
+
+		expect(config).toEqual({
+			apiKey: "consumer-key",
+			apiSecret: "consumer-secret",
+			callback: "oob",
+			accessToken: "access-token",
+			accessTokenSecret: "access-token-secret",
+		});
+	});
+
+	it("reports missing X consumer env vars with the renamed keys", () => {
+		expect(() =>
+			buildXOAuth1({
+				X_CONSUMER_KEY: "consumer-key",
+				X_ACCESS_TOKEN: "access-token",
+				X_ACCESS_TOKEN_SECRET: "access-token-secret",
+			})
+		).toThrow("X_CONSUMER_KEY_SECRET environment variable is required.");
+	});
 });

packages/release/src/announcement.ts

@@ -578,20 +578,26 @@ export async function publishXAnnouncement(
 	announcement: string,
 	environment: Record<string, string | undefined>
 ): Promise<void> {
-	const oauth1 = new OAuth1({
-		apiKey: getRequiredEnv(environment, "X_API_KEY"),
-		apiSecret: getRequiredEnv(environment, "X_API_SECRET"),
-		callback: "oob",
-		accessToken: getRequiredEnv(environment, "X_ACCESS_TOKEN"),
-		accessTokenSecret: getRequiredEnv(environment, "X_ACCESS_TOKEN_SECRET"),
+	const client = new Client({
+		oauth1: buildXOAuth1(environment),
 	});
-
-	const client = new Client({ oauth1 });
 	await client.posts.create({
 		text: announcement,
 	});
 }
 
+export function buildXOAuth1(
+	environment: Record<string, string | undefined>
+): OAuth1 {
+	return new OAuth1({
+		apiKey: getRequiredEnv(environment, "X_CONSUMER_KEY"),
+		apiSecret: getRequiredEnv(environment, "X_CONSUMER_KEY_SECRET"),
+		callback: "oob",
+		accessToken: getRequiredEnv(environment, "X_ACCESS_TOKEN"),
+		accessTokenSecret: getRequiredEnv(environment, "X_ACCESS_TOKEN_SECRET"),
+	});
+}
+
 function renderSummary(result: RunWidgetReleaseAnnouncementResult): string {
 	const lines = [
 		"## Widget Release Announcements",