Preserve UTF-8 SMTP domains#274
Closed
vhafdal wants to merge 1 commit into
Closed
Conversation
Author
|
Superseded by consolidated PR #284. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves UTF-8 domain names when SMTP command parsing materializes domain strings for
HELO,EHLO,MAIL FROM, andRCPT TO.Root cause
SmtpServer already tokenizes bytes >=
0x80as text and advertisesSMTPUTF8. The mailbox local-part path decoded with UTF-8, but the domain side still used the default ASCII helper. That meant internationalizeddomains such as
dæmi.iswere not preserved after parsing.Changes
HELOandEHLOdomains with UTF-8.EHLO dæmi.isMAIL FROM:<þorsteinn@dæmi.is> SMTPUTF8RCPT TO:<þorsteinn@dæmi.is>Validation
dotnet build src/SmtpServer/SmtpServer.csprojdotnet build src/SmtpServer.Tests/SmtpServer.Tests.csprojgit diff --checkFull test execution was not run on my host because the tests target
net8.0, while the installed runtimes are .NET 9 and .NET 10.