Skip to content

Support RCPT ESMTP parameters#276

Closed
vhafdal wants to merge 1 commit into
cosullivan:masterfrom
vhafdal:codex/rcpt-esmtp-parameters
Closed

Support RCPT ESMTP parameters#276
vhafdal wants to merge 1 commit into
cosullivan:masterfrom
vhafdal:codex/rcpt-esmtp-parameters

Conversation

@vhafdal

@vhafdal vhafdal commented Jul 15, 2026

Copy link
Copy Markdown

Summary

Adds parser and command support for optional ESMTP parameters on RCPT TO commands.

Changes

  • Parse trailing ESMTP parameters after the RCPT path.
  • Expose parsed recipient parameters on RcptCommand.Parameters.
  • Add a compatibility overload to ISmtpCommandFactory.CreateRcpt so existing implementations that only override CreateRcpt(IMailbox) continue to work.
  • Update SmtpCommandFactory and command tracing to include RCPT parameters.
  • Add parser tests for valid DSN-style parameters and invalid parameter syntax.

Validation

  • dotnet build src/SmtpServer/SmtpServer.csproj
  • dotnet build src/SmtpServer.Tests/SmtpServer.Tests.csproj
  • git diff --check

dotnet test src/SmtpServer.Tests/SmtpServer.Tests.csproj --filter "FullyQualifiedName~SmtpParserTests" --no-build could not execute on this host because the test project targets net8.0 and this machine only has .NET 9/10 runtimes installed.

Existing warnings remain: XML docs in AuthCommand, the package missing-readme warning, MailKit vulnerability warning, and existing xUnit analyzer warnings.

@vhafdal

vhafdal commented Jul 15, 2026

Copy link
Copy Markdown
Author

Superseded by consolidated PR #284.

@vhafdal vhafdal closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant