Support RCPT ESMTP parameters#276
Closed
vhafdal wants to merge 1 commit into
Closed
Conversation
Author
|
Superseded by consolidated PR #284. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds parser and command support for optional ESMTP parameters on
RCPT TOcommands.Changes
RcptCommand.Parameters.ISmtpCommandFactory.CreateRcptso existing implementations that only overrideCreateRcpt(IMailbox)continue to work.SmtpCommandFactoryand command tracing to include RCPT parameters.Validation
dotnet build src/SmtpServer/SmtpServer.csprojdotnet build src/SmtpServer.Tests/SmtpServer.Tests.csprojgit diff --checkdotnet test src/SmtpServer.Tests/SmtpServer.Tests.csproj --filter "FullyQualifiedName~SmtpParserTests" --no-buildcould not execute on this host because the test project targetsnet8.0and this machine only has .NET 9/10 runtimes installed.Existing warnings remain: XML docs in
AuthCommand, the package missing-readme warning, MailKit vulnerability warning, and existing xUnit analyzer warnings.