SS-3 Fix PROXY TCP version validation#277
Closed
vhafdal wants to merge 1 commit into
Closed
Conversation
vhafdal
marked this pull request as ready for review
July 15, 2026 11:38
Author
|
Superseded by consolidated PR #284. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PROXY v1 TCP version validation in
SmtpParserso TCP4 and TCP6 parsing only accepts the exact single-digit version token expected by each branch.Root Cause
The TCP4/TCP6 parser checks used
&&when rejecting invalid tokens, which allowed invalid numeric versions such asTCP5or multi-digit variants such asTCP46to pass the version check and continue parsing.Changes
4for TCP4 parsing.6for TCP6 parsing.Validation
DOTNET_ROLL_FORWARD=Major dotnet test src/SmtpServer.Tests/SmtpServer.Tests.csprojJira