SS-2 Tighten SMTP parser syntax handling#278
Closed
vhafdal wants to merge 1 commit into
Closed
Conversation
vhafdal
marked this pull request as ready for review
July 15, 2026 11:43
Author
|
Superseded by consolidated PR #284. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens SMTP parser handling for malformed known commands.
Root Cause
Some command parsers accepted a valid prefix and returned a command without verifying the command ended cleanly.
MAIL FROMalso treated malformed trailing ESMTP parameters as if no parameters were supplied. At the top-levelTryMakepath, syntax errors from recognized commands could be overwritten by later parser attempts and reported as an unrecognized command.Changes
TryMake.MAIL FROMESMTP parameters instead of silently using an empty parameter dictionary.Validation
DOTNET_ROLL_FORWARD=Major dotnet test src/SmtpServer.Tests/SmtpServer.Tests.csprojJira