SS-4 Add streaming DATA message store path#279
Closed
vhafdal wants to merge 2 commits into
Closed
Conversation
Author
|
Benchmark follow-up added in vhafdal:SmtpServer@5df5db2.\n\nCommand used:\n |
vhafdal
marked this pull request as ready for review
July 15, 2026 12:00
Author
|
Superseded by consolidated PR #284. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in streaming message store path for SMTP DATA handling.
Why
The existing DATA flow reads the complete dot-block into a
ReadOnlySequence<byte>before invoking message storage. That preserves compatibility but forces full-message buffering before custom storage can process content. This change lets storage implementations opt into streaming while leaving existingIMessageStoreimplementations untouched.Changes
IStreamingMessageStore, extendingIMessageStorewith aPipeReader-based save method.DataCommandto stream DATA content to stores that implementIStreamingMessageStore.IMessageStore.SaveAsync(... ReadOnlySequence<byte> ...)path for all current consumers.Validation
DOTNET_ROLL_FORWARD=Major dotnet test src/SmtpServer.Tests/SmtpServer.Tests.csprojNotes
Jira