Skip to content

SS-6 Wire NetworkBufferSize into connection pipes#281

Closed
vhafdal wants to merge 1 commit into
cosullivan:masterfrom
vhafdal:ss-6-network-buffer-size
Closed

SS-6 Wire NetworkBufferSize into connection pipes#281
vhafdal wants to merge 1 commit into
cosullivan:masterfrom
vhafdal:ss-6-network-buffer-size

Conversation

@vhafdal

@vhafdal vhafdal commented Jul 15, 2026

Copy link
Copy Markdown

Summary

  • Wire NetworkBufferSize into the PipeReader created for each SMTP connection stream.
  • Preserve the configured buffer size after STARTTLS swaps the underlying stream.
  • Validate NetworkBufferSize values so non-positive sizes fail early.
  • Add tests proving the configured size is observable at the pipe read layer.
  • Document the fix in the changelog.

Verification

  • DOTNET_ROLL_FORWARD=Major dotnet test src/SmtpServer.Tests/SmtpServer.Tests.csproj
    • Passed: 120, Skipped: 1

Notes

  • The option is kept as public API and now matches its existing XML documentation: it controls the size of the buffer used when reading from the network stream.
  • Existing warnings remain unrelated: MailKit NU1902, AuthCommand XML doc warning, and existing xUnit analyzer warnings.

@vhafdal

vhafdal commented Jul 15, 2026

Copy link
Copy Markdown
Author

Superseded by consolidated PR #284.

@vhafdal vhafdal closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant