feat!: more form attributes#352
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4824f19 to
e6b2f3d
Compare
c55425b to
c7ba160
Compare
| /// let rendered = data_list.render(); | ||
| /// ``` | ||
| #[must_use] | ||
| pub fn data_list<I, S>(list: I, id: &str) -> Self |
There was a problem hiding this comment.
I'm not sure if we should force providing id in the constructor, maybe getting rid of it and expecting users to do .attr("id", id") is enough?
There was a problem hiding this comment.
mm, The thing about the datalist element is that the id attr is tightly coupled with the list attribute in the input element (i.e the list attr in the input should match the id attr in the datalist) so if the user forgets to call .attr("id", id) it wont work. I had that as a parameter because it's required for correctness
m4tx
left a comment
There was a problem hiding this comment.
LGTM, but please fix the minor issues I've mentioned before merging.
This PR adds more form attributes to various HTML elements in cot