Draft
Conversation
|
Code Coverage Results:
|
snej
force-pushed
the
fix/threadsafe-websocketimpl
branch
from
5c4fd27 to
15239f2
Compare
snej
force-pushed
the
fix/threadsafe-websocketimpl
branch
from
15239f2 to
07fbbe3
Compare
WebSocketImpl has several methods that are called with the mutex locked, but have to call external code that can call back in and deadlock. The current code has some awkward special-purpose mechanisms to defer those calls until the outer method releases the lock. I haven't figured out the best way to do this, but I added a small utility class that allows for queuing up lambdas that will be called later after the mutex unlocks.
snej
force-pushed
the
fix/threadsafe-websocketimpl
branch
from
07fbbe3 to
1aa40ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.