Conversation
Redocly previews |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy “serverless mode” configuration and code paths from Sync Gateway, while keeping per-bucket authentication support. This simplifies config surface area and eliminates serverless-only behaviors (including serverless-specific connection string defaults and database suspension handling).
Changes:
- Removed
unsupported.serverless.*configuration (structs, flag wiring, validation, and API schema) and serverless-specific connection string defaults. - Removed database suspension logic;
suspendableremains as a deprecated/no-op config field for compatibility. - Cleaned up/renamed tests and removed serverless-specific test coverage.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rest/utilities_testing.go | Removes RestTester serverless setup plumbing and test-only suspend helpers. |
| rest/serverless_test.go | Deletes serverless-mode test suite. |
| rest/server_context.go | Removes serverless-specific inactive DB loading and bucket-spec defaults; removes suspend/unsuspend implementation. |
| rest/replicatortest/replicator_test.go | Renames tests to remove “serverless” terminology. |
| rest/main.go | Removes serverless bootstrap-connection behavior and related option plumbing. |
| rest/handler_config_database.go | Updates DbConfig setup call signature (removes serverless/per-bucket forcing param). |
| rest/database_init_manager_test.go | Updates DbConfig setup call signature in tests. |
| rest/config.go | Makes suspendable explicitly a no-op; removes serverless validation and serverless fetch-caching helpers. |
| rest/config_test.go | Updates DbConfig setup call signature; removes serverless bucket-credential validation tests. |
| rest/config_startup.go | Removes Unsupported.Serverless config and StartupConfig.IsServerless(). |
| rest/config_legacy.go | Updates DbConfig setup call signature for legacy config validation path. |
| rest/config_flags.go | Removes serverless-related unsupported config flags. |
| rest/config_database.go | Removes runtime “suspended” state and serverless-derived defaults for suspendable/import partitions. |
| rest/config_database_test.go | Marks Suspendable as deprecated for default-field coverage expectations. |
| rest/api_test.go | Updates connection-string defaulting tests to no longer expect serverless defaults. |
| rest/adminapitest/admin_api_test.go | Renames test to remove “serverless” terminology. |
| rest/admin_api.go | Updates DbConfig setup call signature for admin API paths. |
| docs/api/components/schemas.yaml | Removes Serverless schema and marks suspendable as deprecated/no-op in API schema. |
| base/rosmar_cluster.go | Removes serverless-only rosmar cluster stub method. |
| base/gocb_dcp_client.go | Removes serverless DCP buffer default constant. |
| base/gocb_connection_string.go | Removes serverless default param set; keeps only general defaults. |
| base/gocb_connection_string_test.go | Removes serverless-params test cases. |
| base/dcp_sharded.go | Removes serverless import-partition defaults and helper. |
| base/constants.go | Removes serverless KV pool/buffer constants. |
| base/bootstrap.go | Removes “force per-bucket auth” behavior; keeps per-bucket authenticators. |
| base/bootstrap_test.go | Updates NewCouchbaseCluster call signature in tests. |
Comment on lines
+376
to
377
| // GetInactiveDatabase attempts to load the database and return it's DatabaseContext, by fetching it from the buckets. | ||
| // This should be used if GetActiveDatabase fails. Turns the database context, a variable to say if the config exists, and an error. |
bbrks
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5377 remove serverless options
unsupported.serverlessandunsupported.serverless.min_config_fetch_intervaloptionssuspendableinto a no-op option.forcePerBucketAuthwas only used by the serverless pathway, per bucket auth is still supportedPre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests