[side-quest/integration-test-utilities-and-cleanup] Integration test utilities and copy-pasta cleanup#618
Conversation
…utilities and copy-pasta cleanup Adds reusable assertion helpers (`withClipboardSentinel`, `withClipboardChanged`, `withClipboardRestored`, `assertClipboardEqualsGeneratedLink`, `assertTerminalBufferEqualsGeneratedLink`, `assertTerminalBufferContainsGeneratedLink`, `assertClipboardPreservedAndTerminalLink`, `assertLogContains`) and converts all call sites across test suite files to use them. ## Changes - New assertion helpers in `clipboardHelpers.ts`, `capturingPtyHelpers.ts`, `logBasedUiAssertions.ts`, and `logHelpers.ts` eliminate repeated clipboard/terminal/log assertion boilerplate - Converted integration test suites to use the new helpers, reducing copy-pasta and making test intent more readable - Fixed broken tests and smart padding issues uncovered during the conversion campaign - Updated CLAUDE.md with shell-quoting gotcha and `:with-extensions --grep` documentation - Removed `expectContextKeys` calls from test suites — those belong to the ContextKeyService extraction (PR #3) and would fail without that infrastructure ## Test Plan - [ ] All 1982 unit tests pass - [ ] Integration tests pass: `pnpm test:release:automated` - [ ] Integration tests pass with extensions: `pnpm test:release:with-extensions`
|
Warning Review limit reached
More reviews will be available in 9 minutes and 50 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (21)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ QA Coverage OK The PR modifies a test case in the QA YAML to automate a previously manual verification of clipboard content and toast appearance, which is a user-visible change. Generated by QA Gap Check (GPT-4o-mini via GitHub Models) |
✅ CI / Integration Tests (with overrides) — run summaryDuration: 1m 3s QA TC IDs: 2 exercised across 1 features Report: View run & artifacts Reproduce locally: Feature breakdown
|
❌ CI / Integration Tests (automated) — run summaryDuration: 10m 53s QA TC IDs: 156 exercised across 0 features Report: View run & artifacts Reproduce locally: Feature breakdown
To re-run failed tests: |
❌ CI / Integration Tests (with extensions) — run summaryDuration: 11m 10s Unit tests: Ran in separate Test & Validate job \342\232\240\357\270\217 Integration test report missing: Runner may have crashed QA TC IDs: 188 exercised across 25 features Report: View run & artifacts Reproduce locally: Feature breakdown
|
Summary
Adds reusable assertion helpers (
withClipboardSentinel,withClipboardChanged,withClipboardRestored,assertClipboardEqualsGeneratedLink,assertTerminalBufferEqualsGeneratedLink,assertTerminalBufferContainsGeneratedLink,assertClipboardPreservedAndTerminalLink,assertLogContains) and converts all call sites across test suite files to use them.Changes
clipboardHelpers.ts,capturingPtyHelpers.ts,logBasedUiAssertions.ts, andlogHelpers.tseliminate repeated clipboard/terminal/log assertion boilerplate:with-extensions --grepdocumentationexpectContextKeyscalls from test suites — those belong to the ContextKeyService extraction (PR Unifyjest.config.jsfiles to explicitly call-out some configs #3) and would fail without that infrastructureTest Plan
pnpm test:release:automatedpnpm test:release:with-extensions