Add passthrough for mirrors file environment variable.#10
Open
jabrouwer82 wants to merge 2 commits into
Open
Conversation
Member
|
Thanks! Will give this a try whenever I have time, prior to merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brew sandboxes installation in such a way that the mirrors.properties file referenced in the docs isnt' easily available. Brew overrides
$HOMEand filters out almost all environment variables that don't start with "HOMEBREW_", so the application config file location is a temporary directory and you can't directly passCOURSIER_MIRRORSor to the installer.This was the most minimally intrusive change I could find to fix the issue, it allows the user to set
HOMEBREW_COURSIER_MIRRORSas an environment variable and the install section of the formula temporarily forwards that value to coursier asCOURSIER_MIRRORS.This should resolve coursier/coursier#1953