Skip to content

fix(run-templates): send plural array IDs to match API schema#76

Merged
lorenjphillips merged 1 commit into
mainfrom
fix/run-templates-plural-ids
May 27, 2026
Merged

fix(run-templates): send plural array IDs to match API schema#76
lorenjphillips merged 1 commit into
mainfrom
fix/run-templates-plural-ids

Conversation

@lorenjphillips
Copy link
Copy Markdown
Contributor

Summary

  • v1 API requires agent_ids / persona_ids / test_set_ids as arrays (min length 1), but the CLI was sending the singular agent_id / persona_id / test_set_id and every run-templates create / update call returned 400 INVALID_ARGUMENT.
  • Updated request models to plural Vec<String>, response model to plural Vec<String> (also brings the cached display in line with the API response shape).
  • CLI flags are now repeatable or comma-delimited:

```
coval run-templates create \
--name "Voice eval" \
--agent-ids agentA,agentB \
--persona-ids p1 --persona-ids p2 \
--test-set-ids ts1
```

Test plan

  • `cargo fmt`, `cargo clippy --all-targets -- -D warnings`, `cargo test` all green locally
  • After release, smoke-test `coval run-templates create` against prod

The v1 API requires agent_ids/persona_ids/test_set_ids as arrays
(min length 1), but the CLI was sending the singular variants and
getting 400 INVALID_ARGUMENT on every create/update call.

Flags are now repeatable or comma-delimited:
  coval run-templates create \
    --agent-ids agentA,agentB \
    --persona-ids p1 --persona-ids p2 \
    --test-set-ids ts1
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@lorenjphillips, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ac710065-4e34-4d19-a73b-7f3991d18c05

📥 Commits

Reviewing files that changed from the base of the PR and between 8c7dc14 and 77cecdb.

📒 Files selected for processing (2)
  • src/client/models/run_template.rs
  • src/commands/run_templates.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/run-templates-plural-ids

Comment @coderabbitai help to get the list of available commands and usage tips.

@lorenjphillips lorenjphillips mentioned this pull request May 27, 2026
1 task
@lorenjphillips lorenjphillips merged commit b143d9e into main May 27, 2026
7 checks passed
@lorenjphillips lorenjphillips deleted the fix/run-templates-plural-ids branch May 27, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants