Skip to content

Generate cases legend CSS dynamically#164

Open
elchininet wants to merge 1 commit into
covid19cubadata:masterfrom
elchininet:generate_cases_legend_css_dynamically
Open

Generate cases legend CSS dynamically#164
elchininet wants to merge 1 commit into
covid19cubadata:masterfrom
elchininet:generate_cases_legend_css_dynamically

Conversation

@elchininet

Copy link
Copy Markdown

This pull request refactors the repetitive code to generate the colors of the cases-legend and creates a function to generate them dynamically.

So, this:

$('#cases1').css(
    'color',
    'rgba(176,30,34,' +
        logx(factor, (genInfo.max_pros * factor * 0.2) / genInfo.max_pros) +
    ')'
);
$('#cases2').css(
    'color',
    'rgba(176,30,34,' +
        logx(factor, (genInfo.max_pros * factor * 0.4) / genInfo.max_pros) +
    ')'
);
$('#cases3').css(
    'color',
    'rgba(176,30,34,' +
        logx(factor, (genInfo.max_pros * factor * 0.6) / genInfo.max_pros) +
    ')'
);
$('#cases4').css(
    'color',
    'rgba(176,30,34,' +
        logx(factor, (genInfo.max_pros * factor * 0.8) / genInfo.max_pros) +
    ')'
);
$('#cases5').css(
    'color',
    'rgba(176,30,34,' +
        logx(factor, (genInfo.max_pros * factor) / genInfo.max_pros) +
    ')'
);
$('#cases').html(genInfo.max_pros);

Can be replaced by this:

updateCasesLegendCSS(factor, genInfo.max_pros);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant