Skip to content

feat(bw): implement percentage-based rollout #7845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
limitofzero wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −4
Draft

feat(bw): implement percentage-based rollout #7845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...odules/balancesAndAllowances/updaters/CommonPriorityBalancesAndAllowancesUpdater.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ describe('CommonPriorityBalancesAndAllowancesUpdater', () => {
beforeEach(() => {
jest.clearAllMocks()

mockUseFeatureFlags.mockReturnValue({ isBwEnabled: true } as ReturnType<typeof useFeatureFlags>)
mockUseFeatureFlags.mockReturnValue({ bwEnabledPercentage: 100 } as ReturnType<typeof useFeatureFlags>)
mockUseWalletInfo.mockReturnValue({
account: '0x0000000000000000000000000000000000000001',
chainId: SupportedChainId.MAINNET,
Expand Down Expand Up @@ -209,7 +209,7 @@ describe('CommonPriorityBalancesAndAllowancesUpdater', () => {
)

it('mounts only the multicall stack when the bw feature flag is disabled', () => {
mockUseFeatureFlags.mockReturnValue({ isBwEnabled: false } as ReturnType<typeof useFeatureFlags>)
mockUseFeatureFlags.mockReturnValue({ bwEnabledPercentage: 0 } as ReturnType<typeof useFeatureFlags>)

renderWithHealth(healthy())

Expand Down
16 changes: 14 additions & 2 deletions ...src/modules/balancesAndAllowances/updaters/CommonPriorityBalancesAndAllowancesUpdater.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ import { usePriorityTokenAddresses } from 'modules/trade'
import { useBridgeCustomTokensForChain } from '../hooks/useBridgeCustomTokensForChain'
import { useOrdersFilledEventsTrigger } from '../hooks/useOrdersFilledEventsTrigger'

// Percentage-based rollout: hashes the wallet address into a stable 0..99
// bucket and enables the watcher for buckets below `percentage`. Same account
// -> same bucket, so the toggle is sticky per wallet across sessions/tabs.
// - 100 -> everyone (including not-yet-connected wallets)
// - 0 / undefined / out-of-range / non-number -> nobody
function shouldEnableBalancesWatcher(account: string | undefined, percentage: number | boolean | undefined): boolean {
if (percentage === 100) return true
if (typeof percentage !== 'number' || !account || percentage < 0 || percentage > 100) return false

return BigInt(account) % 100n < percentage
}

export function CommonPriorityBalancesAndAllowancesUpdater(): ReactNode {
const { chainId: sourceChainId, source: sourceChainSource } = useSourceChainId()
// Bridge buy-tokens are only meaningful for the output/buy selector. The input/sell selector on a non-wallet chain
Expand All @@ -32,7 +44,7 @@ export function CommonPriorityBalancesAndAllowancesUpdater(): ReactNode {
const balancesContext = useBalancesContext()
const balancesAccount = balancesContext.account || account

const { isBwEnabled } = useFeatureFlags()
const { bwEnabledPercentage } = useFeatureFlags()

const priorityTokenAddresses = usePriorityTokenAddresses()
const priorityTokenAddressesAsArray = useMemo(() => {
Expand Down Expand Up @@ -69,7 +81,7 @@ export function CommonPriorityBalancesAndAllowancesUpdater(): ReactNode {
const bridgeTokenList = useBridgeCustomTokensForChain(sourceChainId)

const { isRecovering: isWatcherRecovering } = useAtomValue(balancesWatcherHealthAtom)
const isWatcherActive = isBwEnabled && !isNonEvmChain(sourceChainId)
const isWatcherActive = shouldEnableBalancesWatcher(account, bwEnabledPercentage) && !isNonEvmChain(sourceChainId)
// Mount the multicall stack when:
// - the watcher isn't running at all (bw flag off, or non-EVM chain), OR
// - the watcher is in recovery — sticky from the first failure until the next
Expand Down
Loading