fix ut

tpfz · tpfz · commit 11a6b2aff854 · 2026-01-22T17:58:17.000+08:00
diff --git a/backend/modules/evaluation/application/convertor/experiment/expt_test.go b/backend/modules/evaluation/application/convertor/experiment/expt_test.go
@@ -2133,10 +2133,11 @@ func TestEvalConfConvert_ConvertToEntity_SetScoreWeight(t *testing.T) {
 
 		// 验证 ScoreWeight 被正确设置
 		for _, conf := range result.ConnectorConf.EvaluatorsConf.EvaluatorConf {
-			if conf.EvaluatorVersionID == 101 {
+			switch conf.EvaluatorVersionID {
+			case 101:
 				assert.NotNil(t, conf.ScoreWeight)
 				assert.Equal(t, scoreWeight1, *conf.ScoreWeight)
-			} else if conf.EvaluatorVersionID == 102 {
+			case 102:
 				assert.NotNil(t, conf.ScoreWeight)
 				assert.Equal(t, scoreWeight2, *conf.ScoreWeight)
 			}
diff --git a/backend/modules/evaluation/application/experiment_app_test.go b/backend/modules/evaluation/application/experiment_app_test.go
@@ -3379,9 +3379,9 @@ func TestExperimentApplication_ListExperimentTemplates_FilterOptionAndDefaultSor
 
 	t.Run("FilterOption为nil，不设置filters", func(t *testing.T) {
 		req := &exptpb.ListExperimentTemplatesRequest{
-			WorkspaceID: workspaceID,
-			PageNumber:  gptr.Of(int32(1)),
-			PageSize:    gptr.Of(int32(10)),
+			WorkspaceID:  workspaceID,
+			PageNumber:   gptr.Of(int32(1)),
+			PageSize:     gptr.Of(int32(10)),
 			FilterOption: nil,
 		}
 
@@ -5010,7 +5010,7 @@ func TestExperimentApplication_UpdateAnnotateRecord(t *testing.T) {
 				DoAndReturn(func(_ context.Context, exptID int64, spaceID int64, session *entity.Session) (*entity.Experiment, error) {
 					return &entity.Experiment{
 						ID:        exptID,
-						SpaceID:    spaceID,
+						SpaceID:   spaceID,
 						CreatedBy: "user1",
 					}, nil
 				})
diff --git a/backend/modules/evaluation/domain/service/expt_manage_impl_test.go b/backend/modules/evaluation/domain/service/expt_manage_impl_test.go
@@ -1162,7 +1162,7 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 		mgrNoRepo.templateRepo = nil
 		expts := []*entity.Experiment{
 			{
-				ID: 1,
+				ID:               1,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: 100},
 			},
 		}
@@ -1184,11 +1184,11 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 		templateID2 := int64(200)
 		expts := []*entity.Experiment{
 			{
-				ID: 1,
+				ID:               1,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID1},
 			},
 			{
-				ID: 2,
+				ID:               2,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID2},
 			},
 		}
@@ -1222,9 +1222,10 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 				// 返回对应的模板
 				result := make([]*entity.ExptTemplate, 0, 2)
 				for _, id := range ids {
-					if id == templateID1 {
+					switch id {
+					case templateID1:
 						result = append(result, templates[0])
-					} else if id == templateID2 {
+					case templateID2:
 						result = append(result, templates[1])
 					}
 				}
@@ -1242,7 +1243,7 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 		templateID := int64(100)
 		expts := []*entity.Experiment{
 			{
-				ID: 1,
+				ID:               1,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID},
 			},
 		}
@@ -1267,11 +1268,11 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 		templateID2 := int64(200)
 		expts := []*entity.Experiment{
 			{
-				ID: 1,
+				ID:               1,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID1},
 			},
 			{
-				ID: 2,
+				ID:               2,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID2},
 			},
 		}
@@ -1318,7 +1319,7 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 		templateID := int64(100)
 		expts := []*entity.Experiment{
 			{
-				ID: 1,
+				ID:               1,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID},
 			},
 		}
@@ -1341,11 +1342,11 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 		templateID2 := int64(200)
 		expts := []*entity.Experiment{
 			{
-				ID: 1,
+				ID:               1,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID1},
 			},
 			{
-				ID: 2,
+				ID:               2,
 				ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID2},
 			},
 		}
@@ -1372,9 +1373,10 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {
 				// 返回对应的模板
 				result := make([]*entity.ExptTemplate, 0, 2)
 				for _, id := range ids {
-					if id == templateID1 {
+					switch id {
+					case templateID1:
 						result = append(result, templates[0])
-					} else if id == templateID2 {
+					case templateID2:
 						result = append(result, templates[1])
 					}
 				}
diff --git a/backend/modules/evaluation/domain/service/expt_template_impl_test.go b/backend/modules/evaluation/domain/service/expt_template_impl_test.go

Original file line number	Diff line number	Diff line change
`@@ -1162,7 +1162,7 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1162`	`1162`	`mgrNoRepo.templateRepo = nil`
`1163`	`1163`	`expts := []*entity.Experiment{`
`1164`	`1164`	`{`
`1165`		`- ID: 1,`
	`1165`	`+ ID: 1,`
`1166`	`1166`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: 100},`
`1167`	`1167`	`},`
`1168`	`1168`	`}`
`@@ -1184,11 +1184,11 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1184`	`1184`	`templateID2 := int64(200)`
`1185`	`1185`	`expts := []*entity.Experiment{`
`1186`	`1186`	`{`
`1187`		`- ID: 1,`
	`1187`	`+ ID: 1,`
`1188`	`1188`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID1},`
`1189`	`1189`	`},`
`1190`	`1190`	`{`
`1191`		`- ID: 2,`
	`1191`	`+ ID: 2,`
`1192`	`1192`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID2},`
`1193`	`1193`	`},`
`1194`	`1194`	`}`
`@@ -1222,9 +1222,10 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1222`	`1222`	`// 返回对应的模板`
`1223`	`1223`	`result := make([]*entity.ExptTemplate, 0, 2)`
`1224`	`1224`	`for _, id := range ids {`
`1225`		`- if id == templateID1 {`
	`1225`	`+ switch id {`
	`1226`	`+ case templateID1:`
`1226`	`1227`	`result = append(result, templates[0])`
`1227`		`- } else if id == templateID2 {`
	`1228`	`+ case templateID2:`
`1228`	`1229`	`result = append(result, templates[1])`
`1229`	`1230`	`}`
`1230`	`1231`	`}`
`@@ -1242,7 +1243,7 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1242`	`1243`	`templateID := int64(100)`
`1243`	`1244`	`expts := []*entity.Experiment{`
`1244`	`1245`	`{`
`1245`		`- ID: 1,`
	`1246`	`+ ID: 1,`
`1246`	`1247`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID},`
`1247`	`1248`	`},`
`1248`	`1249`	`}`
`@@ -1267,11 +1268,11 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1267`	`1268`	`templateID2 := int64(200)`
`1268`	`1269`	`expts := []*entity.Experiment{`
`1269`	`1270`	`{`
`1270`		`- ID: 1,`
	`1271`	`+ ID: 1,`
`1271`	`1272`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID1},`
`1272`	`1273`	`},`
`1273`	`1274`	`{`
`1274`		`- ID: 2,`
	`1275`	`+ ID: 2,`
`1275`	`1276`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID2},`
`1276`	`1277`	`},`
`1277`	`1278`	`}`
`@@ -1318,7 +1319,7 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1318`	`1319`	`templateID := int64(100)`
`1319`	`1320`	`expts := []*entity.Experiment{`
`1320`	`1321`	`{`
`1321`		`- ID: 1,`
	`1322`	`+ ID: 1,`
`1322`	`1323`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID},`
`1323`	`1324`	`},`
`1324`	`1325`	`}`
`@@ -1341,11 +1342,11 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1341`	`1342`	`templateID2 := int64(200)`
`1342`	`1343`	`expts := []*entity.Experiment{`
`1343`	`1344`	`{`
`1344`		`- ID: 1,`
	`1345`	`+ ID: 1,`
`1345`	`1346`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID1},`
`1346`	`1347`	`},`
`1347`	`1348`	`{`
`1348`		`- ID: 2,`
	`1349`	`+ ID: 2,`
`1349`	`1350`	`ExptTemplateMeta: &entity.ExptTemplateMeta{ID: templateID2},`
`1350`	`1351`	`},`
`1351`	`1352`	`}`
`@@ -1372,9 +1373,10 @@ func TestExptMangerImpl_fillExptTemplates(t *testing.T) {`
`1372`	`1373`	`// 返回对应的模板`
`1373`	`1374`	`result := make([]*entity.ExptTemplate, 0, 2)`
`1374`	`1375`	`for _, id := range ids {`
`1375`		`- if id == templateID1 {`
	`1376`	`+ switch id {`
	`1377`	`+ case templateID1:`
`1376`	`1378`	`result = append(result, templates[0])`
`1377`		`- } else if id == templateID2 {`
	`1379`	`+ case templateID2:`
`1378`	`1380`	`result = append(result, templates[1])`
`1379`	`1381`	`}`
`1380`	`1382`	`}`