Skip to content

Commit 1bd9d63

Browse files
committed
fix lint
1 parent 0cde089 commit 1bd9d63

3 files changed

Lines changed: 15 additions & 12 deletions

File tree

backend/modules/evaluation/application/convertor/evaluator/openapi.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,13 @@ func openapiAccessProtocolFromEntity(protocol entity.EvaluatorAccessProtocol) *o
189189
case entity.EvaluatorAccessProtocolFaasHTTPOld:
190190
return gptr.Of(openapiEvaluator.EvaluatorAccessProtocolFaasHTTP)
191191
case entity.EvaluatorAccessProtocolRPC, entity.EvaluatorAccessProtocolFaasHTTP:
192-
t := openapiEvaluator.EvaluatorAccessProtocol(protocol)
192+
t := protocol
193193
return &t
194194
default:
195195
if protocol == "" {
196196
return nil
197197
}
198-
t := openapiEvaluator.EvaluatorAccessProtocol(protocol)
198+
t := protocol
199199
return &t
200200
}
201201
}
@@ -206,7 +206,7 @@ func OpenAPIEvaluatorHTTPInfoDO2DTO(do *entity.EvaluatorHTTPInfo) *openapiEvalua
206206
}
207207
var method *openapiEvaluator.EvaluatorHTTPMethod
208208
if do.Method != nil {
209-
m := openapiEvaluator.EvaluatorHTTPMethod(*do.Method)
209+
m := *do.Method
210210
method = &m
211211
}
212212
return &openapiEvaluator.EvaluatorHTTPInfo{
@@ -221,7 +221,7 @@ func OpenAPIEvaluatorHTTPInfoDTO2DO(dto *openapiEvaluator.EvaluatorHTTPInfo) *en
221221
}
222222
var method *entity.EvaluatorHTTPMethod
223223
if dto.Method != nil {
224-
method = (*entity.EvaluatorHTTPMethod)(dto.Method)
224+
method = dto.Method
225225
}
226226
return &entity.EvaluatorHTTPInfo{
227227
Method: method,

backend/modules/evaluation/application/convertor/experiment/openapi_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1964,7 +1964,7 @@ func TestOpenAPIAggregateDataDO2DTO(t *testing.T) {
19641964
}
19651965

19661966
distData := &entity.AggregateData{
1967-
DataType: entity.ScoreDistribution,
1967+
DataType: entity.ScoreDistribution,
19681968
ScoreDistribution: &entity.ScoreDistributionData{
19691969
ScoreDistributionItems: []*entity.ScoreDistributionItem{
19701970
{Score: "0.8", Count: 10, Percentage: 0.5},

backend/modules/evaluation/application/eval_openapi_app_test.go

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3851,8 +3851,8 @@ func TestEvalOpenAPIApplication_SubmitExptFromTemplateOApi(t *testing.T) {
38513851
WorkspaceID: workspaceID,
38523852
},
38533853
TripleConfig: &entity.ExptTemplateTuple{
3854-
EvalSetID: 100,
3855-
EvalSetVersionID: 200,
3854+
EvalSetID: 100,
3855+
EvalSetVersionID: 200,
38563856
},
38573857
}
38583858
}
@@ -3865,9 +3865,10 @@ func TestEvalOpenAPIApplication_SubmitExptFromTemplateOApi(t *testing.T) {
38653865
wantID int64
38663866
}{
38673867
{
3868-
name: "nil request",
3869-
req: nil,
3870-
setup: func(_ *rpcmocks.MockIAuthProvider, _ *servicemocks.MockIExptTemplateManager, _ *servicemocks.MockIExptManager, _ *fakeExperimentApp) {},
3868+
name: "nil request",
3869+
req: nil,
3870+
setup: func(_ *rpcmocks.MockIAuthProvider, _ *servicemocks.MockIExptTemplateManager, _ *servicemocks.MockIExptManager, _ *fakeExperimentApp) {
3871+
},
38713872
wantErr: errno.CommonInvalidParamCode,
38723873
},
38733874
{
@@ -3877,7 +3878,8 @@ func TestEvalOpenAPIApplication_SubmitExptFromTemplateOApi(t *testing.T) {
38773878
TemplateID: gptr.Of(templateID),
38783879
Name: gptr.Of("exp"),
38793880
},
3880-
setup: func(_ *rpcmocks.MockIAuthProvider, _ *servicemocks.MockIExptTemplateManager, _ *servicemocks.MockIExptManager, _ *fakeExperimentApp) {},
3881+
setup: func(_ *rpcmocks.MockIAuthProvider, _ *servicemocks.MockIExptTemplateManager, _ *servicemocks.MockIExptManager, _ *fakeExperimentApp) {
3882+
},
38813883
wantErr: errno.CommonInvalidParamCode,
38823884
},
38833885
{
@@ -3887,7 +3889,8 @@ func TestEvalOpenAPIApplication_SubmitExptFromTemplateOApi(t *testing.T) {
38873889
TemplateID: gptr.Of(int64(0)),
38883890
Name: gptr.Of("exp"),
38893891
},
3890-
setup: func(_ *rpcmocks.MockIAuthProvider, _ *servicemocks.MockIExptTemplateManager, _ *servicemocks.MockIExptManager, _ *fakeExperimentApp) {},
3892+
setup: func(_ *rpcmocks.MockIAuthProvider, _ *servicemocks.MockIExptTemplateManager, _ *servicemocks.MockIExptManager, _ *fakeExperimentApp) {
3893+
},
38913894
wantErr: errno.CommonInvalidParamCode,
38923895
},
38933896
{

0 commit comments

Comments
 (0)