Skip to content

Commit e786786

Browse files
committed
fix(evaluation): lint
1 parent d75c72b commit e786786

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

backend/modules/evaluation/domain/service/expt_lifecycle_event_impl.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,22 @@ func (h *ExptLifecycleEventHandlerImpl) HandleLifecycleEvent(ctx context.Context
3737

3838
switch event.ToStatus {
3939
case entity.ExptStatus_Success, entity.ExptStatus_Failed, entity.ExptStatus_Terminated, entity.ExptStatus_SystemTerminated:
40-
return h.sendNotifyCard(ctx, expt)
40+
return h.sendNotifyCard(ctx, event, expt)
4141
default:
4242
return nil
4343
}
4444
}
4545

46-
func (h *ExptLifecycleEventHandlerImpl) sendNotifyCard(ctx context.Context, expt *entity.Experiment) error {
46+
func (h *ExptLifecycleEventHandlerImpl) sendNotifyCard(ctx context.Context, event *entity.ExptLifecycleEvent, expt *entity.Experiment) error {
47+
if event.ToStatus != expt.Status {
48+
return nil
49+
}
4750
userInfos, err := h.userProvider.MGetUserInfo(ctx, []string{expt.CreatedBy})
4851
if err != nil {
4952
return err
5053
}
5154
if len(userInfos) != 1 || userInfos[0] == nil || len(gptr.Indirect(userInfos[0].Email)) == 0 {
52-
logs.CtxWarn(ctx, "expt %s notify card without target email", expt.ID)
55+
logs.CtxWarn(ctx, "expt %v notify card without target email", expt.ID)
5356
return nil
5457
}
5558
cardID, param := buildExptNotifyParam(expt)

backend/modules/evaluation/domain/service/expt_manage_execution_impl.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ func (e *ExptMangerImpl) sendNotifyCard(ctx context.Context, expt *entity.Experi
334334
return err
335335
}
336336
if len(userInfos) != 1 || userInfos[0] == nil || len(gptr.Indirect(userInfos[0].Email)) == 0 {
337-
logs.CtxWarn(ctx, "expt %s notify card without target email", expt.ID)
337+
logs.CtxWarn(ctx, "expt %v notify card without target email", expt.ID)
338338
return nil
339339
}
340340
cardID, param := buildExptNotifyParam(expt)

0 commit comments

Comments
 (0)