[fix][foundation]: authRes slice contain a nil item#100
Merged
Conversation
Change-Id: Id4d8d1809f35c77291de793175750156493917a9
|
|
cyang302
approved these changes
Aug 13, 2025
cyang302
changed the title
wsx864321
pushed a commit
to wsx864321/coze-loop
that referenced
this pull request
Aug 19, 2025
FIX: authRes slice contain a nil item Change-Id: Id4d8d1809f35c77291de793175750156493917a9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Id4d8d1809f35c77291de793175750156493917a9
What type of PR is this?
fix: fix authRes slice contain a empty item
old way
authRes := make([]*authModel.SubjectActionObjectAuthRes, len(request.Auths)) for _, authObject := range request.Auths { isAllowed := true for _, object := range authObject.Objects { if object.SpaceID != nil && object.GetSpaceID() != strconv.FormatInt(spaceID, 10) { isAllowed = false break } } authRes = append(authRes, &authModel.SubjectActionObjectAuthRes{ SubjectActionObjects: authObject, IsAllowed: ptr.Of(isUserSpace && isAllowed), }) }Initialization method for the first row， would set a nil item to authRes
Check the PR title.
[fix][backend] fix authRes slice contain a empty item