Skip to content

Feat/optimize task prompt pilot#188

Merged
xueyizheng merged 42 commits into
mainfrom
feat/optimize_task_prompt_pilot
Sep 23, 2025
Merged

Feat/optimize task prompt pilot#188
xueyizheng merged 42 commits into
mainfrom
feat/optimize_task_prompt_pilot

Conversation

@tpfz
Copy link
Copy Markdown
Collaborator

@tpfz tpfz commented Sep 16, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

biwang75678 and others added 22 commits September 9, 2025 14:56
…/coze-loop into feat/optimize_task_prompt_pilot
…ontrol

Generated with Coda

Co-Authored-By: Coda <noreply@coda.com>
…ontrol

Generated with Coda

Co-Authored-By: Coda <noreply@coda.com>
…/coze-loop into feat/optimize_task_prompt_pilot
…ontrol

Generated with Coda

Co-Authored-By: Coda <noreply@coda.com>
…ontrol

Generated with Coda

Co-Authored-By: Coda <noreply@coda.com>
…/coze-loop into feat/optimize_task_prompt_pilot
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 16, 2025

CLA assistant check
All committers have signed the CLA.

@xueyizheng xueyizheng force-pushed the feat/optimize_task_prompt_pilot branch from 2d488da to 2c78ede Compare September 16, 2025 14:07
tpfz and others added 5 commits September 16, 2025 22:10
…/coze-loop into feat/optimize_task_prompt_pilot
…r across evaluation layers

(LogID: 20250916174951010091110134879D498)

Co-Authored-By: Coda <coda@bytedance.com>
… files

(LogID: 20250916174951010091110134879D498)

Co-Authored-By: Coda <coda@bytedance.com>
…mock files

(LogID: 20250916174951010091110134879D498)

Co-Authored-By: Coda <coda@bytedance.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 88.09524% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ion/domain/service/evaluator_source_prompt_impl.go 90.00% 4 Missing and 2 partials ⚠️
backend/infra/external/benefit/noop.go 0.00% 4 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   58.81%   61.57%   +2.75%     
==========================================
  Files         512      470      -42     
  Lines       53303    50004    -3299     
==========================================
- Hits        31352    30791     -561     
+ Misses      19570    16943    -2627     
+ Partials     2381     2270     -111     
Flag Coverage Δ
unittests 61.57% <88.09%> (+2.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/infra/external/benefit/benifit.go 40.00% <ø> (ø)
backend/modules/evaluation/domain/entity/param.go 58.06% <ø> (ø)
...odules/evaluation/domain/service/evaluator_impl.go 78.28% <100.00%> (ø)
backend/modules/prompt/application/execute.go 83.68% <100.00%> (ø)
backend/modules/prompt/domain/service/execute.go 66.85% <100.00%> (+0.76%) ⬆️
backend/infra/external/benefit/noop.go 0.00% <0.00%> (ø)
...ion/domain/service/evaluator_source_prompt_impl.go 70.49% <90.00%> (+1.26%) ⬆️

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9567c...17244d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xueyizheng xueyizheng marked this pull request as ready for review September 18, 2025 03:29
Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码审查总结

我已完成对PR #188的专家级代码审查。本次审查发现了多个需要修复的问题,包括:

🚫 必须修复的问题 (3个)

  1. JSON反序列化参数错误 - sonic.UnmarshalString 缺少指针参数
  2. ResponseFormat逻辑错误 - 可能导致空指针风险
  3. JSON标签破坏性变更 - 可能影响向后兼容性

🚨 应该修复的问题 (3个)

  1. 测试用例命名与逻辑不一致 - 测试代码中变量命名混淆
  2. 测试断言逻辑错误 - expectedTracingDisableTracing 概念相反
  3. 业务逻辑变更缺乏说明 - SingleStep 变更缺乏充分验证

💡 建议改进 (1个)

  1. 测试验证逻辑不够明确 - 测试用例缺乏明确的验证逻辑

总体而言,DisableTracing 功能的实现思路是正确的,但在实现细节和测试方面需要进一步完善。请优先修复标记为"必须修复"的问题。

Comment thread backend/modules/evaluation/application/evaluator_app_test.go
Comment thread backend/modules/evaluation/application/evaluator_app_test.go
Comment thread backend/modules/prompt/application/execute.go
HymanShi
HymanShi previously approved these changes Sep 18, 2025
@HymanShi HymanShi self-requested a review September 18, 2025 09:41
@xueyizheng xueyizheng merged commit e4b7973 into main Sep 23, 2025
16 checks passed
@xueyizheng xueyizheng deleted the feat/optimize_task_prompt_pilot branch September 23, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants