Skip to content

[feat][backend] ob add manual annotation#194

Merged
kidkidkid merged 1 commit into
mainfrom
feat/ob_manual_annotation
Dec 22, 2025
Merged

[feat][backend] ob add manual annotation#194
kidkidkid merged 1 commit into
mainfrom
feat/ob_manual_annotation

Conversation

@kidkidkid

Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@codecov

codecov Bot commented Sep 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.21574% with 61 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckend/modules/observability/infra/repo/ck/spans.go 71.75% 28 Missing and 22 partials ⚠️
.../modules/observability/infra/repo/ck/annotation.go 93.13% 3 Missing and 4 partials ⚠️
...bservability/infra/repo/ck/convertor/annotation.go 93.75% 2 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   69.92%   70.03%   +0.11%     
==========================================
  Files         610      611       +1     
  Lines       56835    57091     +256     
==========================================
+ Hits        39740    39984     +244     
+ Misses      14144    14135       -9     
- Partials     2951     2972      +21     
Flag Coverage Δ
unittests 70.03% <82.21%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bservability/infra/repo/ck/convertor/annotation.go 93.75% <93.75%> (ø)
.../modules/observability/infra/repo/ck/annotation.go 90.00% <93.13%> (+90.00%) ⬆️
...ckend/modules/observability/infra/repo/ck/spans.go 75.44% <71.75%> (+4.37%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a30a06...bfc9168. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread backend/modules/observability/infra/repo/ck/spans.go
Comment thread backend/modules/observability/infra/repo/ck/spans.go
@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch 2 times, most recently from 4cfd256 to eecaef2 Compare November 5, 2025 07:22

@CozeLoop CozeLoop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aime code review: added inline comments for correctness and robustness in spans.go (nil-map assignment; filters nil-guard; annoTable validation) and annotation.go (retry backoff). Please see the inline comments for actionable fixes.

Comment thread backend/modules/observability/infra/repo/ck/spans.go
Comment thread backend/modules/observability/infra/repo/ck/spans.go
Comment thread backend/modules/observability/infra/repo/ck/spans.go
Comment thread backend/modules/observability/infra/repo/ck/annotation.go Outdated
@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch 4 times, most recently from 7058797 to 2a5e51f Compare November 5, 2025 12:53
taoyifan89
taoyifan89 previously approved these changes Nov 6, 2025
@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch 2 times, most recently from 9199757 to a0a994c Compare December 19, 2025 09:57
…nd DAO implementation

Co-Authored-By: Coda <coda@bytedance.com>
@kidkidkid kidkidkid force-pushed the feat/ob_manual_annotation branch from a0a994c to bfc9168 Compare December 19, 2025 10:00
@kidkidkid kidkidkid merged commit c584743 into main Dec 22, 2025
17 checks passed
@kidkidkid kidkidkid deleted the feat/ob_manual_annotation branch December 22, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants