Skip to content

[feat][evaluation] increase the trimming length of text#393

Merged
tpfz merged 7 commits into
mainfrom
feat/wzq/fix_trim
Jan 20, 2026
Merged

[feat][evaluation] increase the trimming length of text#393
tpfz merged 7 commits into
mainfrom
feat/wzq/fix_trim

Conversation

@tpfz

@tpfz tpfz commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@mocayo mocayo changed the title [feat][evaluation]增加text长度剪裁 [feat][evaluation] increase the trimming length of text Jan 19, 2026
@codecov

codecov Bot commented Jan 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ules/evaluation/domain/service/expt_result_impl.go 90.47% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   69.93%   69.94%           
=======================================
  Files         618      618           
  Lines       58621    58640   +19     
=======================================
+ Hits        40999    41014   +15     
- Misses      14637    14639    +2     
- Partials     2985     2987    +2     
Flag Coverage Δ
unittests 69.94% <93.10%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/evaluation/pkg/utils/trim.go 95.09% <100.00%> (ø)
...ules/evaluation/domain/service/expt_result_impl.go 64.86% <90.47%> (+0.30%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08480c3...3c08293. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lsy357
lsy357 previously approved these changes Jan 20, 2026
Comment thread backend/modules/evaluation/pkg/utils/trim.go
@tpfz tpfz merged commit 4913e5e into main Jan 20, 2026
16 of 17 checks passed
@tpfz tpfz deleted the feat/wzq/fix_trim branch January 20, 2026 05:24
HearyShen pushed a commit that referenced this pull request Feb 26, 2026
* 增加text长度剪裁

* fix空字符串

* fix trim

---------

Co-authored-by: tpfz <tpfz@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants