Skip to content

[feat][backend]: refactor offline metric & support space_id skip#404

Merged
kidkidkid merged 2 commits into
mainfrom
feat/ob_offline_metric_refactor
Jan 29, 2026
Merged

[feat][backend]: refactor offline metric & support space_id skip#404
kidkidkid merged 2 commits into
mainfrom
feat/ob_offline_metric_refactor

Conversation

@kidkidkid
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@kidkidkid kidkidkid force-pushed the feat/ob_offline_metric_refactor branch from 6f674f8 to 09b4aa9 Compare January 23, 2026 06:30
taoyifan89
taoyifan89 previously approved these changes Jan 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...servability/application/convertor/metric/metric.go 89.47% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   70.85%   70.85%           
=======================================
  Files         624      624           
  Lines       61196    61219   +23     
=======================================
+ Hits        43359    43376   +17     
- Misses      14690    14693    +3     
- Partials     3147     3150    +3     
Flag Coverage Δ
unittests 70.85% <91.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ules/observability/domain/metric/service/metric.go 61.71% <100.00%> (+0.28%) ⬆️
...servability/application/convertor/metric/metric.go 95.74% <89.47%> (-4.26%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9866134...c201309. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kidkidkid kidkidkid force-pushed the feat/ob_offline_metric_refactor branch 5 times, most recently from fbadcd5 to 4e00ec0 Compare January 27, 2026 06:45
@kidkidkid kidkidkid force-pushed the feat/ob_offline_metric_refactor branch from 4e00ec0 to a4b6780 Compare January 27, 2026 06:55
@kidkidkid kidkidkid merged commit d82d38f into main Jan 29, 2026
16 checks passed
@kidkidkid kidkidkid deleted the feat/ob_offline_metric_refactor branch January 29, 2026 06:09
HearyShen pushed a commit that referenced this pull request Feb 26, 2026
* feat(backend): refactor

* feat(backend): add ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants