[fix][clickhouse-init] correct SQL syntax and enable multiquery in bootstrap scripts#409
Closed
night-ci wants to merge 1 commit into
Closed
[fix][clickhouse-init] correct SQL syntax and enable multiquery in bootstrap scripts#409night-ci wants to merge 1 commit into
night-ci wants to merge 1 commit into
Conversation
- Add missing comma after `evaluator_weighted_score` column in `evaluation.sql` to fix ClickHouse table creation syntax error - Enable `--multiquery` flag in `clickhouse-client` invocation to support multiple SQL statements (including CREATE TABLE with skip indexes) in a single .sql file These changes ensure the initialization script runs successfully when bootstrap SQL files contain compound statements or skip index definitions.
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the ClickHouse bootstrap initialization.
First, the evaluation.sql file was missing a comma after the evaluator_weighted_score column definition, which caused a syntax error during table creation when skip indexes were present.
Second, the clickhouse-client command in entrypoint.sh did not use the --multiquery flag, which is required to execute multiple SQL statements such as CREATE TABLE followed by ALTER TABLE in a single .sql file. Both changes are necessary for successful database initialization in Docker environments. The fix has been verified locally with ClickHouse version 23.8.