Skip to content

[feat][evaluation] evalset filter items#430

Merged
Celoria merged 17 commits into
mainfrom
feat/evalset/filter
Feb 27, 2026
Merged

[feat][evaluation] evalset filter items#430
Celoria merged 17 commits into
mainfrom
feat/evalset/filter

Conversation

@Celoria
Copy link
Copy Markdown
Collaborator

@Celoria Celoria commented Feb 9, 2026

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@Celoria Celoria changed the title feat: filter with evalset item [feat][evaluation] evalset filter items Feb 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ckend/modules/evaluation/infra/rpc/data/dataset.go 0.00% 10 Missing ⚠️
...dules/evaluation/application/evaluation_set_app.go 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (48.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   72.88%   72.88%   -0.01%     
==========================================
  Files         624      624              
  Lines       62318    62323       +5     
==========================================
+ Hits        45422    45423       +1     
- Misses      13721    13724       +3     
- Partials     3175     3176       +1     
Flag Coverage Δ
unittests 72.88% <48.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../evaluation/application/convertor/common/common.go 97.36% <100.00%> (+0.01%) ⬆️
...modules/evaluation/application/eval_openapi_app.go 88.77% <100.00%> (ø)
backend/modules/evaluation/domain/entity/common.go 79.78% <ø> (ø)
backend/modules/evaluation/domain/entity/param.go 64.28% <ø> (ø)
...luation/domain/service/evaluation_set_item_impl.go 95.18% <100.00%> (+0.05%) ⬆️
...es/evaluation/domain/service/expt_annotate_impl.go 78.78% <100.00%> (ø)
...ion/domain/service/expt_run_scheduler_mode_impl.go 79.05% <100.00%> (ø)
...dules/evaluation/application/evaluation_set_app.go 16.01% <0.00%> (-0.06%) ⬇️
...ckend/modules/evaluation/infra/rpc/data/dataset.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83610be...16b7bf0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lvyingparker
lvyingparker previously approved these changes Feb 25, 2026
@Celoria Celoria force-pushed the feat/evalset/filter branch from fd4ad1d to 16b7bf0 Compare February 27, 2026 05:29
@lvyingparker lvyingparker self-requested a review February 27, 2026 06:11
@Celoria Celoria merged commit 34b145e into main Feb 27, 2026
17 of 18 checks passed
@Celoria Celoria deleted the feat/evalset/filter branch February 27, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants