[fix][evaluation] target/evaluator err msg conv#445
Conversation
CozeLoop
left a comment
There was a problem hiding this comment.
Overall review:
- The changes centralize error message normalization for EvalTarget and Evaluator flows using the shared configuration-driven ExptErrCtrl, and remove ad-hoc overriding of target error messages to a generic internal string.
- The new
convEvalTargetRunErrhelper inEvalTargetServiceImplmirrors existing behavior on the evaluator side, ensuring that non-custom error codes are normalized while custom codes keep their dedicated messages. - The adjustments in
ExptItemEvalCtxExecutor.storeTurnRunResultavoid double-converting messages and keep behavior consistent with the new error conversion pipeline. - Lock TTL reductions in item and scheduler event handlers are conservative and do not introduce obvious correctness or concurrency issues.
- Thrift
api.op_typemetadata updates now better match the semantics of the underlying HTTP operations (create/update/list).
I did not find correctness, concurrency, or obvious security issues in the modified Go code. Suggestions and impact analysis are documented in the internal review report on our side.
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (68.18%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 73.83% 73.83% -0.01%
==========================================
Files 626 626
Lines 64804 64821 +17
==========================================
+ Hits 47848 47860 +12
- Misses 13709 13711 +2
- Partials 3247 3250 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
What type of PR is this?
fix
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes