Skip to content

[fix][evaluation] target/evaluator err msg conv#445

Merged
lsy357 merged 9 commits into
mainfrom
fix/evalidlop
Mar 4, 2026
Merged

[fix][evaluation] target/evaluator err msg conv#445
lsy357 merged 9 commits into
mainfrom
fix/evalidlop

Conversation

@lsy357

@lsy357 lsy357 commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

fix

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@CozeLoop CozeLoop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall review:

  • The changes centralize error message normalization for EvalTarget and Evaluator flows using the shared configuration-driven ExptErrCtrl, and remove ad-hoc overriding of target error messages to a generic internal string.
  • The new convEvalTargetRunErr helper in EvalTargetServiceImpl mirrors existing behavior on the evaluator side, ensuring that non-custom error codes are normalized while custom codes keep their dedicated messages.
  • The adjustments in ExptItemEvalCtxExecutor.storeTurnRunResult avoid double-converting messages and keep behavior consistent with the new error conversion pipeline.
  • Lock TTL reductions in item and scheduler event handlers are conservative and do not introduce obvious correctness or concurrency issues.
  • Thrift api.op_type metadata updates now better match the semantics of the underlying HTTP operations (create/update/list).

I did not find correctness, concurrency, or obvious security issues in the modified Go code. Suggestions and impact analysis are documented in the internal review report on our side.

@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/evaluation/domain/service/expt_run_item_impl.go 0.00% 3 Missing ⚠️
...odules/evaluation/domain/service/evaluator_impl.go 66.66% 1 Missing and 1 partial ⚠️
...d/modules/evaluation/domain/service/target_impl.go 81.81% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (68.18%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   73.83%   73.83%   -0.01%     
==========================================
  Files         626      626              
  Lines       64804    64821      +17     
==========================================
+ Hits        47848    47860      +12     
- Misses      13709    13711       +2     
- Partials     3247     3250       +3     
Flag Coverage Δ
unittests 73.83% <68.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ules/evaluation/domain/service/expt_result_impl.go 66.68% <ø> (+0.07%) ⬆️
...luation/domain/service/expt_run_item_event_impl.go 72.60% <100.00%> (ø)
...on/domain/service/expt_run_scheduler_event_impl.go 75.21% <100.00%> (ø)
...odules/evaluation/domain/service/evaluator_impl.go 74.38% <66.66%> (-0.10%) ⬇️
...d/modules/evaluation/domain/service/target_impl.go 76.51% <81.81%> (+0.06%) ⬆️
...es/evaluation/domain/service/expt_run_item_impl.go 66.07% <0.00%> (+0.39%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a97cf2...295281f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lsy357 lsy357 merged commit f27d2fb into main Mar 4, 2026
14 of 16 checks passed
@lsy357 lsy357 deleted the fix/evalidlop branch March 4, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants