Skip to content

[feat][backend]: support compound sub-metric name matching in shouldTrav…#497

Merged
kidkidkid merged 2 commits intomainfrom
feat/ob_metric_refactor
Apr 28, 2026
Merged

[feat][backend]: support compound sub-metric name matching in shouldTrav…#497
kidkidkid merged 2 commits intomainfrom
feat/ob_metric_refactor

Conversation

@kidkidkid
Copy link
Copy Markdown
Collaborator

…erseMetric and add retry tests

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ervability/domain/metric/service/offline_metric.go 88.23% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   77.13%   77.14%           
=======================================
  Files         650      650           
  Lines       72511    72525   +14     
=======================================
+ Hits        55934    55948   +14     
  Misses      13242    13242           
  Partials     3335     3335           
Flag Coverage Δ
unittests 77.14% <91.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ace/service/trace/span_processor/chat_processor.go 88.57% <100.00%> (+1.07%) ⬆️
...ervability/domain/metric/service/offline_metric.go 87.89% <88.23%> (+0.96%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbab6ea...c32e001. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kidkidkid kidkidkid force-pushed the feat/ob_metric_refactor branch from fc37204 to 8cb05ec Compare April 28, 2026 03:39
Copy link
Copy Markdown
Collaborator

@Ev4nFeng Ev4nFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@kidkidkid kidkidkid merged commit d624a41 into main Apr 28, 2026
16 checks passed
@kidkidkid kidkidkid deleted the feat/ob_metric_refactor branch April 28, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants