[feat][evaluation] add expt lifecycle event#499
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (77.44%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 76.99% 77.01% +0.01%
==========================================
Files 647 649 +2
Lines 71513 71612 +99
==========================================
+ Hits 55063 55153 +90
- Misses 13142 13152 +10
+ Partials 3308 3307 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
CozeLoop
left a comment
There was a problem hiding this comment.
Requesting changes. Main blockers: (1) lifecycle notification is triggered via MQ but currently lacks an idempotency guard, so retries/duplicate deliveries can spam users with duplicate cards; (2) wrong fmt verb %s is used for int64 expt IDs in logs. Non-blocking: consider aligning MQ consumer context (logid/session) with existing consumers, and make card content depend on event.ToStatus to avoid late/duplicate event inconsistency.
What type of PR is this?
fix
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes