Skip to content

[feat][backend]: fix metric query#509

Merged
kidkidkid merged 1 commit intomainfrom
feat/metric_query_fix
Apr 28, 2026
Merged

[feat][backend]: fix metric query#509
kidkidkid merged 1 commit intomainfrom
feat/metric_query_fix

Conversation

@kidkidkid
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@kidkidkid kidkidkid changed the title [feat][backend]: fix metric query [feat][backend] fix metric query Apr 28, 2026
@kidkidkid kidkidkid changed the title [feat][backend] fix metric query [feat][backend]: fix metric query Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@Ev4nFeng Ev4nFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@kidkidkid kidkidkid merged commit 7a3ce58 into main Apr 28, 2026
11 of 13 checks passed
@kidkidkid kidkidkid deleted the feat/metric_query_fix branch April 28, 2026 13:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ervability/domain/metric/service/offline_metric.go 50.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   77.14%   77.13%   -0.01%     
==========================================
  Files         650      650              
  Lines       72525    72527       +2     
==========================================
- Hits        55950    55947       -3     
- Misses      13241    13244       +3     
- Partials     3334     3336       +2     
Flag Coverage Δ
unittests 77.13% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ervability/domain/metric/service/offline_metric.go 87.65% <50.00%> (-0.24%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16cfe74...5b7958e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants