[fix][backend] add MaxBytes limit to ListSpansRepeat to prevent…#568
Merged
Conversation
… OOM in trajectory backfill When a traceID contains a large number of spans, ListSpansRepeat would fetch all pages into memory without any bound, potentially causing OOM in TCE instances during backfill tasks. This adds a configurable MaxBytes parameter to ListSpansRepeat. When the accumulated span size exceeds the limit, it returns ErrMaxBytesExceeded. GetTrajectories catches this error, logs a warning, and returns an empty trajectory map to skip oversized traces gracefully. The limit is configured per workspace via BackfillConfig.TrajectoryMaxBytes. When unset (0), the original unlimited behavior is preserved.
SharkeyChen
changed the title
kidkidkid
approved these changes
Jun 30, 2026
JqRrt
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… OOM in trajectory backfill
When a traceID contains a large number of spans, ListSpansRepeat would fetch all pages into memory without any bound, potentially causing OOM in TCE instances during backfill tasks.
This adds a configurable MaxBytes parameter to ListSpansRepeat. When the accumulated span size exceeds the limit, it returns ErrMaxBytesExceeded. GetTrajectories catches this error, logs a warning, and returns an empty trajectory map to skip oversized traces gracefully.
The limit is configured per workspace via BackfillConfig.TrajectoryMaxBytes. When unset (0), the original unlimited behavior is preserved.
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes