fix: document deletion bug (#2248)

m3ngyang · web-flow · commit 42147df459d0 · 2025-10-10T10:28:39.000Z
diff --git a/backend/domain/knowledge/service/knowledge.go b/backend/domain/knowledge/service/knowledge.go
@@ -433,14 +433,14 @@ func (k *knowledgeSVC) DeleteDocument(ctx context.Context, request *DeleteDocume
 		}
 	}
 
-	err = k.documentRepo.DeleteDocuments(ctx, []int64{request.DocumentID})
+	sliceIDs, err := k.sliceRepo.GetDocumentSliceIDs(ctx, []int64{request.DocumentID})
 	if err != nil {
+		logs.CtxErrorf(ctx, "[DeleteDocument] get document slice ids failed, err: %v", err)
 		return errorx.New(errno.ErrKnowledgeDBCode, errorx.KV("msg", err.Error()))
 	}
 
-	sliceIDs, err := k.sliceRepo.GetDocumentSliceIDs(ctx, []int64{request.DocumentID})
+	err = k.documentRepo.DeleteDocuments(ctx, []int64{request.DocumentID})
 	if err != nil {
-		logs.CtxErrorf(ctx, "[DeleteDocument] get document slice ids failed, err: %v", err)
 		return errorx.New(errno.ErrKnowledgeDBCode, errorx.KV("msg", err.Error()))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -433,14 +433,14 @@ func (k knowledgeSVC) DeleteDocument(ctx context.Context, request DeleteDocume`
`433`	`433`	`}`
`434`	`434`	`}`
`435`	`435`
`436`		`- err = k.documentRepo.DeleteDocuments(ctx, []int64{request.DocumentID})`
	`436`	`+ sliceIDs, err := k.sliceRepo.GetDocumentSliceIDs(ctx, []int64{request.DocumentID})`
`437`	`437`	`if err != nil {`
	`438`	`+ logs.CtxErrorf(ctx, "[DeleteDocument] get document slice ids failed, err: %v", err)`
`438`	`439`	`return errorx.New(errno.ErrKnowledgeDBCode, errorx.KV("msg", err.Error()))`
`439`	`440`	`}`
`440`	`441`
`441`		`- sliceIDs, err := k.sliceRepo.GetDocumentSliceIDs(ctx, []int64{request.DocumentID})`
	`442`	`+ err = k.documentRepo.DeleteDocuments(ctx, []int64{request.DocumentID})`
`442`	`443`	`if err != nil {`
`443`		`- logs.CtxErrorf(ctx, "[DeleteDocument] get document slice ids failed, err: %v", err)`
`444`	`444`	`return errorx.New(errno.ErrKnowledgeDBCode, errorx.KV("msg", err.Error()))`
`445`	`445`	`}`
`446`	`446`