fix(knowledge): avoid panic on empty table raw content#2679
Open
MackDing wants to merge 1 commit intocoze-dev:mainfrom
Open
fix(knowledge): avoid panic on empty table raw content#2679MackDing wants to merge 1 commit intocoze-dev:mainfrom
MackDing wants to merge 1 commit intocoze-dev:mainfrom
Conversation
|
|
Author
|
Quick follow-up: this PR is ready on my side. If there is a preferred fix direction or any additional test / guard you’d like for the empty-table case, I’m happy to update it quickly. Thanks for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
code=105000005and panic onindex out of range [0] with length 0packInsertDataaccessedslice.RawContent[0]without validating thatRawContentexisted and contained a valid table payloadFix
RawContentTest
PATH=/home/clawos/work/.local-go/go/bin:$PATH GOPATH=/home/clawos/work/.gopath GOCACHE=/home/clawos/work/.gocache GOMODCACHE=/home/clawos/work/.gomodcache GOPROXY=https://proxy.golang.org,direct GOSUMDB=sum.golang.org GOFLAGS='-buildvcs=false -p=1' /home/clawos/work/.local-go/go/bin/go test -gcflags='all=-N -l' ./domain/knowledge/service -run 'Test(EventHandle|PackInsertData)' -count=1 -v