Skip to content

fix(editor): fix caret issue with PrefixElement #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stream-pipe merged 1 commit into from
Jun 17, 2026
Merged

fix(editor): fix caret issue with PrefixElement #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@coze-editor/react-components/fix-prefix-element-caret_2026-06-17-11-51.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@coze-editor/react-components",
"comment": "fix caret issue with PrefixElement",
"type": "patch"
}
],
"packageName": "@coze-editor/react-components",
"email": "stream-pipe@users.noreply.github.com"
}
2 changes: 1 addition & 1 deletion packages/text-editor/dev/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createRoot } from 'react-dom/client';
import Page from './pages/highlight';
import Page from './pages/prefix';
import './index.css';

createRoot(document.getElementById('app')!).render(<Page />);
7 changes: 1 addition & 6 deletions packages/text-editor/react-components/src/prefix-element/dom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ function textRange(node: Text, from: number, to = from) {
return range;
}

function flattenRect(rect: Rect, left: boolean) {
const x = left ? rect.left : rect.right;
return { left: x, right: x, top: rect.top, bottom: rect.bottom };
}

function clientRectsFor(dom: Node) {
if (dom.nodeType == 3) {
return textRange(dom as Text, 0, dom.nodeValue!.length).getClientRects();
Expand All @@ -33,6 +28,6 @@ function clientRectsFor(dom: Node) {
}
}

export { flattenRect, clientRectsFor };
export { clientRectsFor };

export type { Rect };
4 changes: 2 additions & 2 deletions packages/text-editor/react-components/src/prefix-element/react.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { useHTMLElement, useLatest } from '@coze-editor/react-hooks';
import { useInjector } from '@coze-editor/react';
import { Decoration, EditorView, keymap, WidgetType } from '@codemirror/view';

import { clientRectsFor, flattenRect } from './dom';
import { clientRectsFor } from './dom';

class PrefixElementWidget extends WidgetType {
constructor(
Expand Down Expand Up @@ -43,7 +43,7 @@ class PrefixElementWidget extends WidgetType {
return null;
}
const style = window.getComputedStyle(dom.parentNode as HTMLElement);
const rect = flattenRect(rects[0], style.direction != 'rtl');
const rect = rects[0];
const lineHeight = parseInt(style.lineHeight);
if (rect.bottom - rect.top > lineHeight * 1.5) {
return {
Expand Down
Loading