Open notes and OO docs inside shared drives (#4557)

Author: nono

docs/shared-drives.md

@@ -405,3 +405,21 @@ Downloads an old version of the file content.
 Identical call to [`GET /files/download/:file-id/:version-id`](files.md#get-filesdownloadfile-idversion-id)
 but over a shared drive. See there for request and response examples, the only
 difference is the URL.
+
+## Notes
+
+### POST /sharings/drives/:id/notes
+
+Create a note inside a shared drive. Identical to [`POST /notes`](notes.md#post-notes).
+
+### GET /sharings/drives/:id/notes/:file-id/open
+
+Return the parameters to build the URL where the note can be opened.
+Identical to [`GET /notes/:file-id/open`](notes.md#get-notesidopen).
+
+## Office
+
+### GET /sharings/drives/:id/office/:file-id/open
+
+Returns the parameters to open an office document. Identical to
+[`GET /office/:file-id/open`](office.md#get-officeidopen).

web/notes/notes.go

@@ -322,7 +322,7 @@ func ForceNoteSync(c echo.Context) error {
 // parameters to build the URL where the note can be opened.
 func OpenNoteURL(c echo.Context) error {
 	inst := middlewares.GetInstance(c)
-	fileID := c.Param("id")
+	fileID := c.Param("file-id")
 	open, err := sharing.OpenNote(inst, fileID)
 	if err != nil {
 		return wrapError(err)
@@ -510,7 +510,7 @@ func Routes(router *echo.Group) {
 	router.PUT("/:id/title", ChangeTitle)
 	router.PUT("/:id/telepointer", PutTelepointer)
 	router.POST("/:id/sync", ForceNoteSync)
-	router.GET("/:id/open", OpenNoteURL)
+	router.GET("/:file-id/open", OpenNoteURL)
 	router.PUT("/:id/schema", UpdateNoteSchema)
 	router.POST("/:id/images", UploadImage)
 	router.POST("/:id/:image-id/copy", CopyImage)

web/office/office.go

@@ -20,7 +20,7 @@ import (
 // Open returns the parameters to open an office document.
 func Open(c echo.Context) error {
 	inst := middlewares.GetInstance(c)
-	fileID := c.Param("id")
+	fileID := c.Param("file-id")
 	open, err := sharing.OpenOffice(inst, fileID)
 	if err != nil {
 		return wrapError(err)
@@ -101,7 +101,7 @@ func Callback(c echo.Context) error {
 
 // Routes sets the routing for the collaborative edition of office documents.
 func Routes(router *echo.Group) {
-	router.GET("/:id/open", Open)
+	router.GET("/:file-id/open", Open)
 	router.POST("/keys/:key", FileByKey)
 	router.POST("/callback", Callback)
 }

web/sharings/drives.go

@@ -16,6 +16,8 @@ import (
 	"github.com/cozy/cozy-stack/pkg/jsonapi"
 	"github.com/cozy/cozy-stack/web/files"
 	"github.com/cozy/cozy-stack/web/middlewares"
+	"github.com/cozy/cozy-stack/web/notes"
+	"github.com/cozy/cozy-stack/web/office"
 	"github.com/labstack/echo/v4"
 )
 
@@ -315,6 +317,22 @@ func FileDownloadHandler(c echo.Context, inst *instance.Instance, s *sharing.Sha
 	return files.FileDownloadHandler(c)
 }
 
+// CreateNote allows to create a note inside a shared drive.
+func CreateNote(c echo.Context, inst *instance.Instance, s *sharing.Sharing) error {
+	return notes.CreateNote(c)
+}
+
+// OpenNoteURL returns the parameters to open a note inside a shared drive.
+func OpenNoteURL(c echo.Context, inst *instance.Instance, s *sharing.Sharing) error {
+	return notes.OpenNoteURL(c)
+}
+
+// OpenOffice returns the parameter to open an office document inside a shared
+// drive.
+func OpenOffice(c echo.Context, inst *instance.Instance, s *sharing.Sharing) error {
+	return office.Open(c)
+}
+
 // Find the directory linked to the drive sharing and return it if the user
 // requesting it has the proper permissions.
 func getSharingDir(c echo.Context, inst *instance.Instance, s *sharing.Sharing) (*vfs.DirDoc, error) {
@@ -372,6 +390,10 @@ func drivesRoutes(router *echo.Group) {
 	drive.DELETE("/trash/:file-id", proxy(DestroyFileHandler, true))
 
 	drive.DELETE("/:file-id", proxy(TrashHandler, true))
+
+	drive.POST("/notes", proxy(CreateNote, true))
+	drive.GET("/notes/:file-id/open", proxy(OpenNoteURL, true))
+	drive.GET("/office/:file-id/open", proxy(OpenOffice, true))
 }
 
 func proxy(fn func(c echo.Context, inst *instance.Instance, s *sharing.Sharing) error, needsAuth bool) echo.HandlerFunc {

web/sharings/drives_test.go

@@ -892,4 +892,90 @@ func TestSharedDrives(t *testing.T) {
 			res.Header("Content-Disposition").IsEqual(`attachment; filename="` + checklistName + `"`)
 		})
 	})
+
+	t.Run("CreateAndOpenNote", func(t *testing.T) {
+		eA := httpexpect.Default(t, tsA.URL)
+		eB := httpexpect.Default(t, tsB.URL)
+
+		t.Run("CreateNoteInSharedDrive", func(t *testing.T) {
+			// Create a note in the shared drive as the owner
+			obj := eA.POST("/sharings/drives/"+sharingID+"/notes").
+				WithHeader("Authorization", "Bearer "+acmeAppToken).
+				WithHeader("Content-Type", "application/json").
+				WithBytes([]byte(`{
+					"data": {
+						"type": "io.cozy.notes.documents",
+						"attributes": {
+							"title": "Meeting Minutes",
+							"dir_id": "` + meetingsID + `",
+							"schema": {
+								"nodes": [
+									["doc", { "content": "block+" }],
+									["paragraph", { "content": "inline*", "group": "block" }],
+									["text", { "group": "inline" }],
+									["bullet_list", { "content": "list_item+", "group": "block" }],
+									["list_item", { "content": "paragraph block*" }]
+								],
+								"marks": [
+									["em", {}],
+									["strong", {}]
+								],
+								"topNode": "doc"
+							}
+						}
+					}
+				}`)).
+				Expect().Status(201).
+				JSON(httpexpect.ContentOpts{MediaType: "application/vnd.api+json"}).
+				Object()
+
+			data := obj.Value("data").Object()
+			data.HasValue("type", "io.cozy.files")
+			noteID := data.Value("id").String().NotEmpty().Raw()
+
+			attrs := data.Value("attributes").Object()
+			attrs.HasValue("type", "file")
+			attrs.HasValue("name", "Meeting Minutes.cozy-note")
+			attrs.HasValue("mime", "text/vnd.cozy.note+markdown")
+
+			meta := attrs.Value("metadata").Object()
+			meta.HasValue("title", "Meeting Minutes")
+			meta.HasValue("version", 0)
+			meta.Value("schema").Object().NotEmpty()
+			meta.Value("content").Object().NotEmpty()
+
+			t.Run("OpenNoteFromSharedDrive", func(t *testing.T) {
+				obj := eB.GET("/sharings/drives/"+sharingID+"/notes/"+noteID+"/open").
+					WithHeader("Authorization", "Bearer "+bettyAppToken).
+					Expect().Status(200).
+					JSON(httpexpect.ContentOpts{MediaType: "application/vnd.api+json"}).
+					Object()
+
+				data := obj.Value("data").Object()
+				data.HasValue("type", consts.NotesURL)
+				data.HasValue("id", noteID)
+
+				attrs := data.Value("attributes").Object()
+				attrs.HasValue("note_id", noteID)
+				attrs.HasValue("subdomain", "nested")
+				attrs.HasValue("instance", acmeInstance.Domain)
+				attrs.Value("public_name").String().NotEmpty()
+			})
+		})
+
+		t.Run("CreateNoteWithoutAuthentication", func(t *testing.T) {
+			eB.POST("/sharings/drives/"+sharingID+"/notes").
+				WithHeader("Content-Type", "application/json").
+				WithBytes([]byte(`{
+					"data": {
+						"type": "io.cozy.notes.documents",
+						"attributes": {
+							"title": "Unauthorized Note",
+							"dir_id": "` + meetingsID + `"
+						}
+					}
+				}`)).
+				Expect().Status(401)
+		})
+	})
 }