feat(api): StoragePool.Spec.DestroyOnDelete consent flag (Phase 10.8 step)

Operators opt into the destructive teardown path explicitly: with
DestroyOnDelete=true (default false), deleting the StoragePool
CRD also runs vgremove --force / zpool destroy + wipefs -a so the
discovery loop can re-publish the freed devices as
PhysicalDevice CRDs.

Default-false matches the GitOps "you delete the manifest, the
CRD goes away, but the on-disk data sticks around for manual
rescue" model — safer than the alternative even though it leaks
unmanaged VGs/zpools across deletes.

The reconciler half (finalizer + actual vgremove call) lands
once Phase 10.1 promotes the satellite's StoragePool reconciler
to a controller-runtime watcher; this commit just lays down the
typed field + admission validation.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Author: kvaps

api/v1alpha1/storagepool_types.go

@@ -53,6 +53,18 @@ type StoragePoolSpec struct {
 	// props is the LINSTOR property map for this pool.
 	// +optional
 	Props map[string]string `json:"props,omitempty"`
+
+	// destroyOnDelete controls whether `kubectl delete storagepool`
+	// also runs the destructive teardown — `vgremove --force` /
+	// `zpool destroy` plus `wipefs -a` so the discovery loop can
+	// re-publish the freed devices as `PhysicalDevice` CRDs.
+	// Default false: deleting the CRD only removes the LINSTOR-side
+	// pool registration; the on-disk VG / zpool stays intact and
+	// can be re-imported manually with `vgchange -ay` / `zpool
+	// import`. Operators must opt in to the destructive path
+	// explicitly. Phase 10.8.
+	// +optional
+	DestroyOnDelete bool `json:"destroyOnDelete,omitempty"`
 }
 
 // StoragePoolStatus is the observed state of a storage pool, populated by

config/crd/bases/blockstor.io.blockstor.io_storagepools.yaml

@@ -39,6 +39,18 @@ spec:
           spec:
             description: spec defines the desired state of StoragePool
             properties:
+              destroyOnDelete:
+                description: |-
+                  destroyOnDelete controls whether `kubectl delete storagepool`
+                  also runs the destructive teardown — `vgremove --force` /
+                  `zpool destroy` plus `wipefs -a` so the discovery loop can
+                  re-publish the freed devices as `PhysicalDevice` CRDs.
+                  Default false: deleting the CRD only removes the LINSTOR-side
+                  pool registration; the on-disk VG / zpool stays intact and
+                  can be re-imported manually with `vgchange -ay` / `zpool
+                  import`. Operators must opt in to the destructive path
+                  explicitly. Phase 10.8.
+                type: boolean
               nodeName:
                 description: |-
                   nodeName is the name of the satellite hosting this pool. Same as the