fix(rest): drop DisallowUnknownFields on CRUD decoders

Java LINSTOR ignores unknown fields. golinstor stuffs GenericPropsModify
fields (override_props, delete_props, ...) into bodies for many shared
upstream types — including Node modify, RG modify, RD modify. Strict
decoding turned every such call into a 400. Match Java's lenient
behavior; we keep the decode in-flight but no longer reject by name.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Author: kvaps

pkg/rest/nodes.go

@@ -78,10 +78,7 @@ func (s *Server) handleNodeGet(w http.ResponseWriter, r *http.Request) {
 func (s *Server) handleNodeCreate(w http.ResponseWriter, r *http.Request) {
 	var n apiv1.Node
 
-	dec := json.NewDecoder(r.Body)
-	dec.DisallowUnknownFields()
-
-	err := dec.Decode(&n)
+	err := json.NewDecoder(r.Body).Decode(&n)
 	if err != nil {
 		writeError(w, http.StatusBadRequest, err.Error())
 
@@ -109,10 +106,7 @@ func (s *Server) handleNodeUpdate(w http.ResponseWriter, r *http.Request) {
 
 	var n apiv1.Node
 
-	dec := json.NewDecoder(r.Body)
-	dec.DisallowUnknownFields()
-
-	err := dec.Decode(&n)
+	err := json.NewDecoder(r.Body).Decode(&n)
 	if err != nil {
 		writeError(w, http.StatusBadRequest, err.Error())
 

pkg/rest/resource_definitions.go

@@ -96,10 +96,7 @@ func (s *Server) handleRDUpdate(w http.ResponseWriter, r *http.Request) {
 
 	var rd apiv1.ResourceDefinition
 
-	dec := json.NewDecoder(r.Body)
-	dec.DisallowUnknownFields()
-
-	err := dec.Decode(&rd)
+	err := json.NewDecoder(r.Body).Decode(&rd)
 	if err != nil {
 		writeError(w, http.StatusBadRequest, err.Error())
 

pkg/rest/resource_groups.go

@@ -61,10 +61,7 @@ func (s *Server) handleRGGet(w http.ResponseWriter, r *http.Request) {
 func (s *Server) handleRGCreate(w http.ResponseWriter, r *http.Request) {
 	var rg apiv1.ResourceGroup
 
-	dec := json.NewDecoder(r.Body)
-	dec.DisallowUnknownFields()
-
-	err := dec.Decode(&rg)
+	err := json.NewDecoder(r.Body).Decode(&rg)
 	if err != nil {
 		writeError(w, http.StatusBadRequest, err.Error())
 
@@ -92,10 +89,7 @@ func (s *Server) handleRGUpdate(w http.ResponseWriter, r *http.Request) {
 
 	var rg apiv1.ResourceGroup
 
-	dec := json.NewDecoder(r.Body)
-	dec.DisallowUnknownFields()
-
-	err := dec.Decode(&rg)
+	err := json.NewDecoder(r.Body).Decode(&rg)
 	if err != nil {
 		writeError(w, http.StatusBadRequest, err.Error())
 

pkg/rest/spawn.go

@@ -65,7 +65,7 @@ func (s *Server) handleSpawn(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	rd := buildSpawnedRD(req, rgName, &rg)
+	rd := buildSpawnedRD(&req, rgName, &rg)
 
 	err = s.Store.ResourceDefinitions().Create(r.Context(), &rd)
 	if err != nil {
@@ -85,7 +85,7 @@ func (s *Server) handleSpawn(w http.ResponseWriter, r *http.Request) {
 	writeJSON(w, http.StatusCreated, rd)
 }
 
-func buildSpawnedRD(req apiv1.ResourceGroupSpawn, rgName string, rg *apiv1.ResourceGroup) apiv1.ResourceDefinition {
+func buildSpawnedRD(req *apiv1.ResourceGroupSpawn, rgName string, rg *apiv1.ResourceGroup) apiv1.ResourceDefinition {
 	rd := apiv1.ResourceDefinition{
 		Name:              req.ResourceDefinitionName,
 		ExternalName:      req.ResourceDefinitionExternal,